You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/12/14 03:13:39 UTC

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Hello Kudu Jenkins, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18097

to review the following change.


Change subject: [java] bump log4j up to 2.16.0 version
......................................................................

[java] bump log4j up to 2.16.0 version

OK, it seems 2.16.0 is the new shiny version to have once the recent
security vulnerability CVE-2021-44228 has been fixed in 2.15.0.

Release notes for the new version of the package is available at [1].

This is a follow-up to a6079a063c8f38166d91956ad46a4ce695a08019.

[1] https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0

Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Reviewed-on: http://gerrit.cloudera.org:8080/18095
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit ea67260aad998db7d34a94d25261e121a668faec)
  Conflicts:
    java/gradle/dependencies.gradle
---
M java/gradle/dependencies.gradle
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/18097/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 06:49:31 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 06:59:25 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 06:59:07 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 08:09:07 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.14.x) [java] bump log4j up to 2.16.0 version

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18097 )

Change subject: [java] bump log4j up to 2.16.0 version
......................................................................

[java] bump log4j up to 2.16.0 version

OK, it seems 2.16.0 is the new shiny version to have once the recent
security vulnerability CVE-2021-44228 has been fixed in 2.15.0.

Release notes for the new version of the package is available at [1].

This is a follow-up to a6079a063c8f38166d91956ad46a4ce695a08019.

[1] https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0

Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Reviewed-on: http://gerrit.cloudera.org:8080/18095
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit ea67260aad998db7d34a94d25261e121a668faec)
  Conflicts:
    java/gradle/dependencies.gradle
Reviewed-on: http://gerrit.cloudera.org:8080/18097
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M java/gradle/dependencies.gradle
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Greg Solovyev: Looks good to me, but someone else must approve
  Andrew Wong: Looks good to me, approved; Verified
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied261b7fdb412839b40a0d68a131963c61b09356
Gerrit-Change-Number: 18097
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)