You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Caleb Rackliffe (Jira)" <ji...@apache.org> on 2022/07/14 16:57:00 UTC
[jira] [Comment Edited] (CASSANDRA-17731) Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566918#comment-17566918 ]
Caleb Rackliffe edited comment on CASSANDRA-17731 at 7/14/22 4:56 PM:
----------------------------------------------------------------------
Committed.
4.0 - [https://github.com/apache/cassandra/commit/d51f90201b2d127166612384a75b4a49da9776d1]
4.1 - [https://github.com/apache/cassandra/commit/9bd32771e3983efdb0b135699a036c91e89b52dd]
trunk - [https://github.com/apache/cassandra/commit/889ca60edc8afd85b4a594442883c1b5efdf3c6b]
was (Author: maedhroz):
Committed.
4.0 - [https://github.com/apache/cassandra/commit/d51f90201b2d127166612384a75b4a49da9776d1]
4.1 - [https://github.com/apache/cassandra/commit/9bd32771e3983efdb0b135699a036c91e89b52dd]
trunk - https://github.com/apache/cassandra/commit/889ca60edc8afd85b4a594442883c1b5efdf3c6b
> Clean up ScheduledExecutors, CommitLog, and MessagingService shutdown for in-JVM dtests
> ---------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17731
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17731
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
> Reporter: Caleb Rackliffe
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> There appear to be two problems w/ the way we shut down {{ScheduledExecutors}} in Instance in 4.0+:
> 1.) We do it twice, Ince as part of a larger batch of shutdown activity, and then again in its own {{parallelRun()}} block.
> 2.) It happens before {{MessagingService}} shuts down, but some messaging-related threads (see {{StreamSession#closeSession()}}) can submit tasks to {{nonPeriodicTasks}}.
> We should do it once, and do it after the {{MessagingService}} has properly shut down.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org