[GitHub] [nifi] jfrazee commented on a change in pull request #4917: NIFI-8346 PutAzureBlobStorage doesn't route to failure despite the exception during upload

[GitBox <gi...@apache.org>]

jfrazee commented on a change in pull request #4917:
URL: https://github.com/apache/nifi/pull/4917#discussion_r599122961



##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##########
@@ -141,14 +142,14 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
                 }
 
                 try {
-                    blob.upload(in, -1, null, null, operationContext);
+                    uploadBlob(blob, operationContext, in);
                     BlobProperties properties = blob.getProperties();
                     attributes.put("azure.container", containerName);
                     attributes.put("azure.primaryUri", blob.getSnapshotQualifiedUri().toString());
                     attributes.put("azure.etag", properties.getEtag());
                     attributes.put("azure.length", String.valueOf(length));
                     attributes.put("azure.timestamp", String.valueOf(properties.getLastModified()));
-                } catch (StorageException | URISyntaxException e) {
+                } catch (StorageException | URISyntaxException | IOException e) {
                     storedException.set(e);
                     throw new IOException(e);

Review comment:
       I should have caught this before but we probably shouldn't double-wrap this.
   ```suggestion
                       throw (e instanceof IOException) ? (IOException) e : new IOException(e);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org