You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/29 07:19:48 UTC
[GitHub] [apisix] kwanhur opened a new pull request #6236: build: make uninstall related files of runtime
kwanhur opened a new pull request #6236:
URL: https://github.com/apache/apisix/pull/6236
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
`make uninstall` on no need of the runtime
<!--- If it fixes an open issue, please link to the issue here. -->
#5225
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6236: build: make uninstall related files of runtime
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6236:
URL: https://github.com/apache/apisix/pull/6236#discussion_r795116859
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -117,6 +117,15 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a
Solution: set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`
+5. If you have no more need of the Apache APISIX runtime, uninstall it.
Review comment:
```suggestion
5. If you have no more need for the Apache APISIX runtime, you could uninstall it like this.
```
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -117,6 +117,15 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a
Solution: set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`
+5. If you have no more need of the Apache APISIX runtime, uninstall it.
+
+```shell
+ # Uninstall apisix command
+ $ make uninstall
+```
+
+ Attention please, this operation will totally **remove** the related files.
Review comment:
```suggestion
Attention please, this operation will totally **remove** the related files.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6236: build: make uninstall related files of runtime
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6236:
URL: https://github.com/apache/apisix/pull/6236#discussion_r795120770
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -117,6 +117,15 @@ Please refer to: [Installing Apache APISIX with Helm Chart](https://github.com/a
Solution: set `LDAP_DIR` with `luarocks config` manually, for example `luarocks config variables.LDAP_DIR /usr/local/opt/openldap/`
+5. If you have no more need of the Apache APISIX runtime, uninstall it.
+
+```shell
+ # Uninstall apisix command
+ $ make uninstall
+```
+
+ Attention please, this operation will totally **remove** the related files.
Review comment:
line#127 aligns at line#97, so it starts with two space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6236: build: make uninstall related files of runtime
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #6236:
URL: https://github.com/apache/apisix/pull/6236#discussion_r795145876
##########
File path: Makefile
##########
@@ -35,6 +35,7 @@ ENV_APISIX ?= $(CURDIR)/bin/apisix
ENV_GIT ?= git
ENV_TAR ?= tar
ENV_INSTALL ?= install
+ENV_RM ?= rm
Review comment:
```suggestion
ENV_RM ?= rm -vf
```
let's extraction of public parts here, :)
##########
File path: Makefile
##########
@@ -340,6 +341,16 @@ install: runtime
$(ENV_INSTALL) apisix/plugins/slslog/*.lua $(ENV_INST_LUADIR)/apisix/plugins/slslog/
+### uninstall : Uninstall the apisix
+.PHONY: uninstall
+uninstall:
+ @$(call func_echo_status, "$@ -> [ Start ]")
+ $(ENV_RM) -vfr /usr/local/apisix
+ $(ENV_RM) -vfr $(ENV_INST_LUADIR)/apisix
+ $(ENV_RM) -vf $(ENV_INST_BINDIR)/apisix
Review comment:
```suggestion
$(ENV_RM) -r /usr/local/apisix
$(ENV_RM) -r $(ENV_INST_LUADIR)/apisix
$(ENV_RM) $(ENV_INST_BINDIR)/apisix
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6236: build: make uninstall related files of runtime
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6236:
URL: https://github.com/apache/apisix/pull/6236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org