[GitHub] [incubator-age] pdpotter commented on pull request #165: Corrects abnormal termination due to incorrect variable in Set Clause.

[GitBox <gi...@apache.org>]

pdpotter commented on pull request #165:
URL: https://github.com/apache/incubator-age/pull/165#issuecomment-999153368


   This PR indeed fixes #160.
   
   I wanted to add following test for this issue, but I wasn't able to run the tests (using `make installcheck`; I will try again with a clean Debian install when I find the time to see if I can reproduce the issue), so I didn't feel confident about creating a PR towards https://github.com/emotionbug/incubator-age/tree/fix-160 for adding this test.
   
   sql (right after https://github.com/apache/incubator-age/blob/master/regress/sql/cypher_set.sql#L134)
   ```
   SELECT * FROM cypher('cypher_set', $$MATCH (n) SET i = 3$$) AS (a agtype);
   ```
   
   regress (right after https://github.com/apache/incubator-age/blob/master/regress/expected/cypher_set.out#L375)
   ```
   SELECT * FROM cypher('cypher_set', $$MATCH (n) SET i = 3$$) AS (a agtype);
   ERROR:  SET clause expects a variable name
   LINE 1: ...ELECT * FROM cypher('cypher_set', $$MATCH (n) SET i = 3$$) A...
                                                                ^
   ```
   
   Do you think it would be worth adding the test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org