You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/24 15:25:54 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #849: MINIFICPP-1261 - Mark ScopeGuard class deprecated

szaszm commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r460123115



##########
File path: extensions/opc/src/opc.cpp
##########
@@ -302,7 +303,7 @@ void Client::traverse(UA_NodeId nodeId, std::function<nodeFoundCallBackFunc> cb,
 
   UA_BrowseResponse bResp = UA_Client_Service_browse(client_, bReq);
 
-  utils::ScopeGuard guard([&bResp]() {
+  gsl::finally guard([&bResp]() {

Review comment:
       `gsl::finally` is a function, not a type. 
   ```suggestion
     const auto guard = gsl::finally([&bResp] {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org