You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/08 10:47:15 UTC
[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #3902:
Remove old orchestration module.
sunbufu opened a new pull request #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902
Fixes #3185.
Changes proposed in this pull request:
- remove old orchestration module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl merged pull request #3902: Remove
old orchestration module.
Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3902: Remove old orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902#discussion_r364685966
##########
File path: sharding-distribution/shardingsphere-src-distribution/pom.xml
##########
@@ -179,17 +179,27 @@
</dependency>
<dependency>
<groupId>org.apache.shardingsphere</groupId>
- <artifactId>sharding-orchestration-core</artifactId>
+ <artifactId>sharding-orchestration-core-new</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.shardingsphere</groupId>
- <artifactId>sharding-orchestration-reg-api</artifactId>
+ <artifactId>sharding-orchestration-center-api</artifactId>
Review comment:
Why not use
sharding-orchestration-center
It includes :
sharding-orchestration-center-api
sharding-orchestration-center-apollo
sharding-orchestration-center-zookeeper-curator
sharding-orchestration-center-nacos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3902: Remove
old orchestration module.
Posted by GitBox <gi...@apache.org>.
sunbufu commented on issue #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902#issuecomment-572548249
/run ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3902: Remove
old orchestration module.
Posted by GitBox <gi...@apache.org>.
sunbufu commented on issue #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902#issuecomment-572346927
/run ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull
request #3902: Remove old orchestration module.
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #3902: Remove old orchestration module.
URL: https://github.com/apache/incubator-shardingsphere/pull/3902#discussion_r364685881
##########
File path: sharding-distribution/sharding-jdbc-distribution/pom.xml
##########
@@ -129,17 +129,27 @@
</dependency>
<dependency>
<groupId>org.apache.shardingsphere</groupId>
- <artifactId>sharding-orchestration-core</artifactId>
+ <artifactId>sharding-orchestration-core-new</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.shardingsphere</groupId>
- <artifactId>sharding-orchestration-reg-api</artifactId>
+ <artifactId>sharding-orchestration-center-api</artifactId>
Review comment:
Why not use
<artifactId>sharding-orchestration-center</artifactId>
It includes :
<modules>
<module>sharding-orchestration-center-api</module>
<module>sharding-orchestration-center-apollo</module>
<module>sharding-orchestration-center-zookeeper-curator</module>
<module>sharding-orchestration-center-nacos</module>
</modules>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services