[GitHub] [airflow-ci-infra] ashb commented on a change in pull request #12: Runners more resilient to docker login failure

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #12:
URL: https://github.com/apache/airflow-ci-infra/pull/12#discussion_r598717976



##########
File path: cloud-init.yml
##########
@@ -145,7 +149,7 @@ write_files:
   - path: /usr/local/bin/stop-runner-if-no-job.sh
     content: |
       #!/bin/bash
-      set -u
+      set -exu -o pipefail

Review comment:
       ```suggestion
         set -eu -o pipefail
   ```

##########
File path: cloud-init.yml
##########
@@ -195,7 +199,7 @@ write_files:
     permissions: '0775'
     content: |
       #!/bin/bash
-
+      set -exu -o pipefail

Review comment:
       ```suggestion
         set -eu -o pipefail
   ```
   This is a cron job, so shouldn't produce needless output.

##########
File path: cloud-init.yml
##########
@@ -123,10 +121,16 @@ write_files:
   - path: /usr/local/sbin/runner-cleanup-workdir.sh
     content: |
       #!/bin/bash
+      set -exu -o pipefail

Review comment:
       ```suggestion
         set -eu -o pipefail
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org