You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/30 12:59:28 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #775: Fix visibility of action buttons for Isos and templates
Pearl1594 opened a new pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775
Despite the template / iso being in 'Ready' state i.e., downloaded, the action buttons (copy and delete) don't appear even in refresh
After fix:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#issuecomment-701374988
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#issuecomment-701379475
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/775 (JID-3549)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#discussion_r499451783
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyTemplate' in $store.getters.apis)"
+ :disabled="!('copyTemplate' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyTemplate(record)" />
</span>
<span style="margin-right: 5px">
<a-button
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && record.isready)"
Review comment:
@rhtyd the legacy UI allows deletion of templates / ISOs incase there is a failure in downloading it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#discussion_r498060019
##########
File path: src/views/image/IsoZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyIso' in $store.getters.apis)"
+ :disabled="!('copyIso' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyIso(record)" />
</span>
<span style="margin-right: 5px">
<a-popconfirm
- v-if="'deleteIso' in $store.getters.apis"
+ v-if="'deleteIso' in $store.getters.apis && record.isready"
Review comment:
@Pearl1594 can you check against old UI, if deleting should be allowed? For example for error on download or uploading of local file?
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyTemplate' in $store.getters.apis)"
+ :disabled="!('copyTemplate' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyTemplate(record)" />
</span>
<span style="margin-right: 5px">
<a-button
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && record.isready)"
Review comment:
@Pearl1594 can you check against old UI, if deleting should be allowed? For example for error on download or uploading of local file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#issuecomment-701374399
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #775: Fix visibility of action buttons for Isos and templates
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#discussion_r499448647
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyTemplate' in $store.getters.apis)"
+ :disabled="!('copyTemplate' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyTemplate(record)" />
</span>
<span style="margin-right: 5px">
<a-button
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && record.isready)"
Review comment:
ping @Pearl1594
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org