You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2022/04/29 15:47:15 UTC

[tika] branch main updated: TIKA-3745 -- turn off file names appearing in the streams for thumbnails and embedded images in odt.

This is an automated email from the ASF dual-hosted git repository.

tallison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new ac10b61ab TIKA-3745 -- turn off file names appearing in the streams for thumbnails and embedded images in odt.
     new 6fb5bb03c Merge remote-tracking branch 'origin/main' into main
ac10b61ab is described below

commit ac10b61ab121254aec0e2c48326e454370c61b44
Author: tallison <ta...@apache.org>
AuthorDate: Fri Apr 29 11:46:52 2022 -0400

    TIKA-3745 -- turn off file names appearing in the streams for thumbnails and embedded images in odt.
---
 .../src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java    | 2 +-
 .../src/test/java/org/apache/tika/parser/odf/ODFParserTest.java         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java
index b559281dd..e5d51a80c 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/odf/OpenDocumentParser.java
@@ -309,7 +309,7 @@ public class OpenDocumentParser extends AbstractParser {
 
                 if (embeddedDocumentUtil.shouldParseEmbedded(embeddedMetadata)) {
                     embeddedDocumentUtil.parseEmbedded(stream, new EmbeddedContentHandler(handler),
-                            embeddedMetadata, true);
+                            embeddedMetadata, false);
                 }
             } else if (extractMacros && embeddedName.contains("Basic/")) {
                 //process all files under Basic/; let maybeHandleMacro figure
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java
index fd9bf6f4d..7a6decc8a 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/test/java/org/apache/tika/parser/odf/ODFParserTest.java
@@ -176,7 +176,7 @@ public class ODFParserTest extends TikaTest {
 
             // Note - contents of maths files not currently supported
             String content = handler.toString().trim();
-            assertEquals("Thumbnails/thumbnail.png", content.trim());
+            assertEquals("", content.trim());
         }
     }