You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by pgfox <gi...@git.apache.org> on 2016/12/07 13:25:22 UTC
[GitHub] activemq-artemis pull request #905: added unit test for setting the user and...
GitHub user pgfox opened a pull request:
https://github.com/apache/activemq-artemis/pull/905
added unit test for setting the user and password in the uri for tcp \u2026
\u2026transport, used in JNDI.
Could not find an example in the existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pgfox/activemq-artemis user_password_url_jndi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #905
----
commit 47a6882e156357abf97969aafc2c076e82c32dab
Author: Pat Fox <pf...@redhat.com>
Date: 2016-12-07T13:22:20Z
added unit test for setting the user and password in the uri for tcp transport, used in JNDI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Posted by pgfox <gi...@git.apache.org>.
Github user pgfox commented on the issue:
https://github.com/apache/activemq-artemis/pull/905
@jbertram sure, I will give that a go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Posted by pgfox <gi...@git.apache.org>.
Github user pgfox commented on the issue:
https://github.com/apache/activemq-artemis/pull/905
@jbertram,
as you suggested, enabled security on the test broker and add a role to ensure credentials passed with connection. Also enabled the default user to ensure existing tests passed without modification - I was trying to keep a small footprint.
Thanks
Pat
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/905
Thanks for the test!
For the sake of thoroughness it would be best if security was enabled on the test broker and the test ensured the credentials set in the URL actually resulted in an authenticated session. If you don't think you can add that I'll go ahead and merge what you have and try to get to it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #905: added unit test for setting the user and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #905: added unit test for setting the user and passwo...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/905
@pgfox you know you can also do new ActiveMQConnectionFactory(uri);, right?
Just asking.. maybe that's something we need to blog about it.. or maybe make it clearer on the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---