You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/04/20 09:13:00 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to PySpark
zhengruifeng opened a new pull request, #40873:
URL: https://github.com/apache/spark/pull/40873
### What changes were proposed in this pull request?
Add `DataFrame.offset` to PySpark
### Why are the changes needed?
`DataFrame.offset` was supported in Scala side and Spark Connect, but it is missing in vanilla PySpark.
### Does this PR introduce _any_ user-facing change?
yes, new API
### How was this patch tested?
added doctests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40873:
URL: https://github.com/apache/spark/pull/40873#discussion_r1173221606
##########
python/pyspark/sql/dataframe.py:
##########
@@ -1273,6 +1273,41 @@ def limit(self, num: int) -> "DataFrame":
jdf = self._jdf.limit(num)
return DataFrame(jdf, self.sparkSession)
+ def offset(self, num: int) -> "DataFrame":
Review Comment:
Should also add to the Python API reference .rst file I believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
URL: https://github.com/apache/spark/pull/40873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #40873:
URL: https://github.com/apache/spark/pull/40873#discussion_r1173223333
##########
python/pyspark/sql/dataframe.py:
##########
@@ -1273,6 +1273,41 @@ def limit(self, num: int) -> "DataFrame":
jdf = self._jdf.limit(num)
return DataFrame(jdf, self.sparkSession)
+ def offset(self, num: int) -> "DataFrame":
Review Comment:
good catch! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40873:
URL: https://github.com/apache/spark/pull/40873#issuecomment-1517257868
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40873: [SPARK-43213][PYTHON] Add `DataFrame.offset` to vanilla PySpark
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40873:
URL: https://github.com/apache/spark/pull/40873#issuecomment-1517098141
cc @HyukjinKwon @xinrong-meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org