You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/02 23:12:54 UTC

[GitHub] apeforest commented on a change in pull request #11742: [MXNET-623] Fixing an integer overflow bug in large NDArray

apeforest commented on a change in pull request #11742: [MXNET-623] Fixing an integer overflow bug in large NDArray
URL: https://github.com/apache/incubator-mxnet/pull/11742#discussion_r222140090
 
 

 ##########
 File path: src/operator/nn/upsampling-inl.h
 ##########
 @@ -48,8 +48,8 @@ enum UpSamplingMultiInputMode {kConcat, kSum};
 }  // namespace up_enum
 
 struct UpSamplingParam : public dmlc::Parameter<UpSamplingParam> {
-  index_t scale;
-  index_t num_filter;
+  int scale;
+  int num_filter;
 
 Review comment:
   I think size_t is usually not preferred in data-structure members, because it has a cross-platform issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services