You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:54:14 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #14058: Specify which logger to update.
jhtimmins opened a new pull request #14058:
URL: https://github.com/apache/airflow/pull/14058
This fixes the test `test_should_load_plugins_from_property`, which is currently quarantined as a "Heisentest".
Current behavior:
The test currently fails because the records that it expects to find in the logger are not present.
Cause:
While the test sets the logger as "DEBUG", it doesn't specify which logger to update. Python loggers are namespaced (typically based on the current file's path), but this has to be defined explicitly. In the absence of a specified logger, any attempts to lookup will return the BaseLogger instance.
The test is therefore updating the log level for the base logger, but when the test runs, the `plugins_manager.py` file defines a namespaced logger `log = logging.getLogger(__name__)` used throughout the file. Since a different logger is used, the original log level, in this case `INFO`, is used. `INFO` is a higher level than `DEBUG`, so the calls to `log.debug()` get filtered out, and when the test looks for log records it finds an empty list.
Fix:
Just specify which logger to update when modifying the log level in the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14058: Specify which logger to update.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14058:
URL: https://github.com/apache/airflow/pull/14058#issuecomment-773133260
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14058: Specify which logger to update.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14058:
URL: https://github.com/apache/airflow/pull/14058#issuecomment-773133260
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14058: Specify which logger to update.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14058:
URL: https://github.com/apache/airflow/pull/14058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14058: Specify which logger to update.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14058:
URL: https://github.com/apache/airflow/pull/14058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #14058: Specify which logger to update.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #14058:
URL: https://github.com/apache/airflow/pull/14058#issuecomment-772974028
@ashb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org