You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/06 03:18:22 UTC
[GitHub] [incubator-inlong] baomingyu opened a new pull request, #3545: [INLONG-3543][inlong-audit]Upgrade netty and log4j version of audit
baomingyu opened a new pull request, #3545:
URL: https://github.com/apache/incubator-inlong/pull/3545
Upgrade netty version to 4.1.72.Final and log4j to log4j2.
Fixes #3543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] pocozh commented on a diff in pull request #3545: [INLONG-3543][Audit] Upgrade netty and log4j version of audit
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #3545:
URL: https://github.com/apache/incubator-inlong/pull/3545#discussion_r843439032
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/ServerMessageHandler.java:
##########
@@ -742,6 +730,26 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E
ctx.close();
}
+ /**
+ * get topic
+ */
+ private String getTopic(String groupId, String streamId) {
Review Comment:
why add this method? It isn't used
##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderManager.java:
##########
@@ -153,7 +150,12 @@ public void send(long sdkTime, AuditApi.BaseCommand baseCommand) {
* @param data
*/
private void sendData(byte[] data) {
- ChannelBuffer dataBuf = ChannelBuffers.wrappedBuffer(data);
+ if (data == null || data.length < 0) {
Review Comment:
why not consider data.length=0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #3545: [INLONG-3543][Audit] Upgrade netty and log4j version of audit
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #3545:
URL: https://github.com/apache/incubator-inlong/pull/3545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org