You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/04/01 22:06:11 UTC
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
[NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Since SSL sockets may return 0 as read bytes due to failure
to decrypt a complete encrypted block, we need to attempt
to read again until a complete block is decrypted.
Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
---
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/64/15964/1
diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
index 8162e0a..b38f0aa 100644
--- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
+++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
@@ -49,7 +49,7 @@
byteBuffer.clear();
byteBuffer.limit(length);
- while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) > 0);
+ while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) >= 0);
if (byteBuffer.remaining() > 0) {
throw new EOFException("could not read all data from source; remaining bytes: " + byteBuffer.remaining());
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/peQ4jUMxkYXaU8Xg6 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 01 Apr 2022 22:13:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
[NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Since SSL sockets may return 0 as read bytes due to failure
to decrypt a complete encrypted block, we need to attempt
to read again until a complete block is decrypted.
Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
---
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/64/15964/1
diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
index 8162e0a..b38f0aa 100644
--- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
+++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
@@ -49,7 +49,7 @@
byteBuffer.clear();
byteBuffer.limit(length);
- while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) > 0);
+ while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) >= 0);
if (byteBuffer.remaining() > 0) {
throw new EOFException("could not read all data from source; remaining bytes: " + byteBuffer.remaining());
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ali Alsuliman <al...@gmail.com>:
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 01 Apr 2022 22:50:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
[NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Since SSL sockets may return 0 as read bytes due to failure
to decrypt a complete encrypted block, we need to attempt
to read again until a complete block is decrypted.
Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
Reviewed-by: Ali Alsuliman <al...@gmail.com>
Tested-by: Murtadha Hubail <mh...@apache.org>
---
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ali Alsuliman: Looks good to me, approved
Murtadha Hubail: Verified
diff --git a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
index 8162e0a..b38f0aa 100644
--- a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
+++ b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/NetworkingUtil.java
@@ -49,7 +49,7 @@
byteBuffer.clear();
byteBuffer.limit(length);
- while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) > 0);
+ while (byteBuffer.remaining() > 0 && socketChannel.read(byteBuffer) >= 0);
if (byteBuffer.remaining() > 0) {
throw new EOFException("could not read all data from source; remaining bytes: " + byteBuffer.remaining());
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: merged
Change in asterixdb[neo]: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Murtadha Hubail <mh...@apache.org>:
Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964 )
Change subject: [NO ISSUE][NET] Attempt to Read SSL Sockets Until EOF
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15964
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia48b7f9f1725c40b2ebfac6fe77b3eb42c426de3
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 01 Apr 2022 22:50:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment