You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/20 22:02:54 UTC

[GitHub] [airflow] lucafuji commented on issue #6870: [AIRFLOW-578] [WIP] Fix check return code

lucafuji commented on issue #6870: [AIRFLOW-578] [WIP] Fix check return code
URL: https://github.com/apache/airflow/pull/6870#issuecomment-568104204
 
 
   > I agreev with the spirit of the change but not the specifics.
   > 
   > I don't think this change should touch base job at all. The issue with not checking return codes is restricted to Local Job
   
   This PR is actually from previously a closed PR, in previous PR one of the reviewer @mistercrunch recommend me to add an on_failure callback in base job.
   Here is the comment
   #1122 (comment).
   
   I'm fine with either way, please let me know you thoughts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services