[MATH] Suggesting new package commons-math.simulation

[Hicham Wahbi <hi...@hotmail.com>]

Hello,

I am interested in contributing to a "commons-math. Simulation" package
since the Monte-Carlo estimation method is listed as an item in the wish
list. 
This is the first time I try to contribute to an open source project. I
actually have already written the code and just need to submit it for
discussion. Please help me jump start.

Thanks,

Hicham Wahbi


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [MATH] Suggesting new package commons-math.simulation

[Luc Maisonobe <Lu...@free.fr>]

In addition to the points identified by Siegfried, could you open a JIRA
issue for this ? You can do this by registering into
https://issues.apache.org/jira/secure/Dashboard.jspa and then select the
 link "create a new issue in project Commons Math" that will appear in
the page https://issues.apache.org/jira/browse/MATH. Describe your
request and once the issue is created you will be able to attach files
to it. This is the proper way to provide patches.

Also if the code is more than a few lines long, which is almost
certainly the case for Monte-Carlo method, we will need a signed
Software Grant (see http://www.apache.org/licenses/#grants). For
discussions about these legal aspects, feel free to contact me directly
off list.

Did you write everything yourself or did you get inspiration from
existing published code ?

Thanks for contributing
Luc

Siegfried Goeschl a écrit :
> Hi Hicham,
> 
> I'm not involved in commons-math but a few general tips ... some obvious
> and some not so obvious
> 
> 1) is the code ASF licence compatible, e.g. not having GPL snippets or
> other license issues
> 2) each files must contain an Apache License Header
> 3) you have to follow the coding and naming conventions used in commons-math
> 4) proper documentation of all methods and fields
> 5) some JUnit tests to prove that the code is correct
> 
>>>From that point on you can integrate your stuff locally in the
> commons-math build and create a patch file ...
> 
> And you have to do 5) - really - if a committer takes the time to apply
> a non-trivial patch everything should go smoothly. If not the risk is
> too big to break the existing code base and you never know when this guy
> has another day to spare for your patch. And after a few weeks the code
> and your patch is out-of-sync causing even more work and delay .....
> 
> Cheers,
> 
> Siegfried Goeschl
> 
> 
> Hicham Wahbi wrote:
>> Hello,
>>
>> I am interested in contributing to a "commons-math. Simulation" package
>> since the Monte-Carlo estimation method is listed as an item in the wish
>> list. 
>> This is the first time I try to contribute to an open source project. I
>> actually have already written the code and just need to submit it for
>> discussion. Please help me jump start.
>>
>> Thanks,
>>
>> Hicham Wahbi
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>>   
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [MATH] Suggesting new package commons-math.simulation

[Siegfried Goeschl <si...@it20one.at>]

Hi Hicham,

I'm not involved in commons-math but a few general tips ... some obvious
and some not so obvious

1) is the code ASF licence compatible, e.g. not having GPL snippets or
other license issues
2) each files must contain an Apache License Header
3) you have to follow the coding and naming conventions used in commons-math
4) proper documentation of all methods and fields
5) some JUnit tests to prove that the code is correct

>From that point on you can integrate your stuff locally in the
commons-math build and create a patch file ...

And you have to do 5) - really - if a committer takes the time to apply
a non-trivial patch everything should go smoothly. If not the risk is
too big to break the existing code base and you never know when this guy
has another day to spare for your patch. And after a few weeks the code
and your patch is out-of-sync causing even more work and delay .....

Cheers,

Siegfried Goeschl


Hicham Wahbi wrote:
> Hello,
>
> I am interested in contributing to a "commons-math. Simulation" package
> since the Monte-Carlo estimation method is listed as an item in the wish
> list. 
> This is the first time I try to contribute to an open source project. I
> actually have already written the code and just need to submit it for
> discussion. Please help me jump start.
>
> Thanks,
>
> Hicham Wahbi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>   

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org