[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3864: [Improve][JDBC] improve jdbc sink option

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3864:
URL: https://github.com/apache/incubator-seatunnel/pull/3864#discussion_r1061522594


##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcConfig.java:
##########
@@ -46,22 +47,20 @@ public class JdbcConfig implements Serializable {
 
     public static final Option<Boolean> AUTO_COMMIT = Options.key("auto_commit").booleanType().defaultValue(DEFAULT_AUTO_COMMIT).withDescription("auto commit");
 
-    public static final Option<Integer> BATCH_SIZE = Options.key("batch_size").intType().noDefaultValue().withDescription("batch size");
+    public static final Option<Integer> BATCH_SIZE = Options.key("batch_size").intType().defaultValue(1000).withDescription("batch size");

Review Comment:
   > 
   
   Theoretically, the performance would be better if the value was higher, but I didn't test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org