You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/11/04 16:45:20 UTC

[GitHub] flink pull request: [FLINK-2968] [streaming] Let AbstractUdfStream...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1328

    [FLINK-2968] [streaming] Let AbstractUdfStreamOperator forward output type information to WindowFunction

    The fold operation needs the output type information to serialize the initial value of it. Therefore, the OutputTypeConfigurable interface was defined. It is called by the StreamGraph upon adding a StreamOperator to the StreamGraph. Since some stream operators, such as the window stream operator, don't work directly on the data, but instead call a WindowFunction for the actual logic, the output type information has to be forwarded to this function to set output type information at the right place.
    
    Thus, the AbstractUdfStreamOperator checks whether its udf function supports the OutputTypeConfigurable interface. If this is the case, then it forwards the output type information to the udf.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixWindowFoldOperation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1328
    
----
commit 0672130514974a6be4e7b6ebf75354d1884dd5c2
Author: Till Rohrmann <tr...@apache.org>
Date:   2015-11-04T15:39:13Z

    [FLINK-2968] [streaming] Let AbstractUdfStreamOperator forward output type information to WindowFunction
    
    The fold operation needs the output type information to serialize the initial value of it. Therefore, the OutputTypeConfigurable interface was defined. It is called by the StreamGraph upon adding a StreamOperator to the StreamGraph. Since some stream operators, such as the window stream operator, don't work directly on the data, but instead call a WindowFunction for the actual logic, the output type information has to be forwarded to this function to set output type information at the right place.
    
    Thus, the AbstractUdfStreamOperator checks whether its udf function supports the OutputTypeConfigurable interface. If this is the case, then it forwards the output type information to the udf.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2968] [streaming] Let AbstractUdfStream...

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/1328#issuecomment-153783915
  
    Good fix. Let's include this for the next RC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2968] [streaming] Let AbstractUdfStream...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1328#issuecomment-153776249
  
    Good point. Will update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2968] [streaming] Let AbstractUdfStream...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1328#issuecomment-153772340
  
    If you add it in `AbstractUdfStreamOperator` then you can remove the `setOutputType` in `WindowOperator` and `NonKeyedWindowOperator`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2968] [streaming] Let AbstractUdfStream...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1328


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---