You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/29 21:30:36 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request, #2890: Add ETH support to PIC32 boards

kasjer opened a new pull request, #2890:
URL: https://github.com/apache/mynewt-core/pull/2890

   - pic32mz_periph_create() now creates eth device if ETH_0 is specified
   - olimex-pic32-hmz144 now includes config settings for RMII/MII
   - olimex-pic32-emz64 includes RMII settings and also gets configuration for on-bard LAN8710 (interrupt pin, and reset pin)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2890: Add ETH support to PIC32 boards

Posted by GitBox <gi...@apache.org>.
kasjer merged PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2890: Add ETH support to PIC32 boards

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890#issuecomment-1264153200

   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2890: Add ETH support to PIC32 boards

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890#issuecomment-1262840609

   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2890: Add ETH support to PIC32 boards

Posted by GitBox <gi...@apache.org>.
sjanc commented on code in PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890#discussion_r984898727


##########
hw/mcu/microchip/pic32mz/src/pic32mz_periph.c:
##########
@@ -372,11 +384,23 @@ pic32mz_periph_i2c_devs(void)
     }
 }
 
+static void
+pic32mz_periph_create_eth(void)
+{
+#if MYNEWT_VAL(ETH_0)
+    int rc;
+    rc = pic32_eth_init(&eth0_cfg);
+    assert(0);

Review Comment:
   this looks odd,   assert(rc == 0) maybe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2890: Add ETH support to PIC32 boards

Posted by GitBox <gi...@apache.org>.
kasjer commented on code in PR #2890:
URL: https://github.com/apache/mynewt-core/pull/2890#discussion_r984919981


##########
hw/mcu/microchip/pic32mz/src/pic32mz_periph.c:
##########
@@ -372,11 +384,23 @@ pic32mz_periph_i2c_devs(void)
     }
 }
 
+static void
+pic32mz_periph_create_eth(void)
+{
+#if MYNEWT_VAL(ETH_0)
+    int rc;
+    rc = pic32_eth_init(&eth0_cfg);
+    assert(0);

Review Comment:
   Polishing before commit not always works as intended.
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org