You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/09/27 15:59:55 UTC

[GitHub] incubator-pirk pull request #103: Drop use of secondary set to track hash co...

GitHub user tellison opened a pull request:

    https://github.com/apache/incubator-pirk/pull/103

    Drop use of secondary set to track hash collisions.

     - Hash collisions can be detected via the key set of ```selectorQueryVecMapping```, so no need for separate ```hashes``` set.
     - Fixed some minor javadoc typos.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tellison/incubator-pirk QueryHashes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit f33fc3d406e601ec4db99e1c8d65d8b5a7c710fe
Author: Tim Ellison <t....@gmail.com>
Date:   2016-09-27T15:44:54Z

    Drop use of secondary set to track hash collisions.
    
     - Hashes already tracked by the map, so no need for separate set.
     - Fixed some minor javadoc typos.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #103: Drop use of secondary set to track hash co...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #103: Drop use of secondary set to track hash collision...

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/103
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---