You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/23 10:09:20 UTC
[GitHub] [spark] yaooqinn opened a new pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
yaooqinn opened a new pull request #28313:
URL: https://github.com/apache/spark/pull/28313
### What changes were proposed in this pull request?
Similar to https://jira.apache.org/jira/browse/SPARK-31507, millennium, century, and decade are not commonly used in most modern platforms.
For example
Negative:
https://docs.snowflake.com/en/sql-reference/functions-date-time.html#supported-date-and-time-parts
https://prestodb.io/docs/current/functions/datetime.html#date_trunc
https://teradata.github.io/presto/docs/148t/functions/datetime.html#date_trunc
https://www.oracletutorial.com/oracle-date-functions/oracle-trunc/
Positive:
https://docs.aws.amazon.com/redshift/latest/dg/r_Dateparts_for_datetime_functions.html
https://www.postgresql.org/docs/9.1/functions-datetime.html#FUNCTIONS-DATETIME-TRUNC
This PR removes these `fmt` support for trunc and date_trunc functions.
### Why are the changes needed?
clean uncommon datetime unit for easy maintenance, we can add them back if they are found very useful later.
### Does this PR introduce any user-facing change?
no, targeting 3.0.0, these are newly added in 3.0.0
### How was this patch tested?
remove and modify existing units tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618489917
cc: @cloud-fan @dongjoon-hyun @HyukjinKwon thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618539945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618973642
**[Test build #121757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121757/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618513336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618846958
**[Test build #121731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121731/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28313:
URL: https://github.com/apache/spark/pull/28313#discussion_r413959146
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1622,7 +1622,15 @@ trait TruncInstant extends BinaryExpression with ImplicitCastInputTypes {
@ExpressionDescription(
usage = """
_FUNC_(date, fmt) - Returns `date` with the time portion of the day truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["week", "mon", "month", "mm", "quarter", "year", "yyyy", "yy", "decade", "century", "millennium"]
+ """,
+ arguments = """
+ Arguments:
+ * date - date value or valid date string
+ * fmt - the format representing the unit to be truncated to
+ - "YEAR", "YYYY", "YY" - truncate to the first date of the year
+ - "QUARTER" - truncate to the closest quarter start date
+ - "MONTH", "MM", "MON" - truncate to the first date of the month
+ - "WEEK" - truncate to the closest Monday
Review comment:
really? so we will move to next Monday if today is Sunday? I thought it's the first date of the current week.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1622,7 +1622,15 @@ trait TruncInstant extends BinaryExpression with ImplicitCastInputTypes {
@ExpressionDescription(
usage = """
_FUNC_(date, fmt) - Returns `date` with the time portion of the day truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["week", "mon", "month", "mm", "quarter", "year", "yyyy", "yy", "decade", "century", "millennium"]
+ """,
+ arguments = """
+ Arguments:
+ * date - date value or valid date string
+ * fmt - the format representing the unit to be truncated to
+ - "YEAR", "YYYY", "YY" - truncate to the first date of the year
+ - "QUARTER" - truncate to the closest quarter start date
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618922593
**[Test build #121731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121731/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28313:
URL: https://github.com/apache/spark/pull/28313#discussion_r414292509
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
##########
@@ -477,7 +477,7 @@ class DateFunctionsSuite extends QueryTest with SharedSparkSession {
checkAnswer(
df.selectExpr("trunc(t, 'decade')"),
- Seq(Row(Date.valueOf("2010-01-01")), Row(Date.valueOf("2010-01-01"))))
+ Seq(Row(null), Row(null)))
Review comment:
can we create an individual test case for these unsupported fields? It's a bit weird to see some null tests randomly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618923064
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121731/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28313:
URL: https://github.com/apache/spark/pull/28313#discussion_r413991291
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1622,7 +1622,15 @@ trait TruncInstant extends BinaryExpression with ImplicitCastInputTypes {
@ExpressionDescription(
usage = """
_FUNC_(date, fmt) - Returns `date` with the time portion of the day truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["week", "mon", "month", "mm", "quarter", "year", "yyyy", "yy", "decade", "century", "millennium"]
+ """,
+ arguments = """
+ Arguments:
+ * date - date value or valid date string
+ * fmt - the format representing the unit to be truncated to
+ - "YEAR", "YYYY", "YY" - truncate to the first date of the year
+ - "QUARTER" - truncate to the closest quarter start date
+ - "MONTH", "MM", "MON" - truncate to the first date of the month
+ - "WEEK" - truncate to the closest Monday
Review comment:
my mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618846958
**[Test build #121731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121731/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618539350
**[Test build #121693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121693/testReport)** for PR 28313 at commit [`84a9b21`](https://github.com/apache/spark/commit/84a9b213fbb1e5bdbf86096cd094e69ceb2aca21).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618831585
**[Test build #121723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121723/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618923054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618974167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618313818
**[Test build #121672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121672/testReport)** for PR 28313 at commit [`5bd7390`](https://github.com/apache/spark/commit/5bd739009f0666cc30af1ac784de290cf8143948).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-619164789
**[Test build #121757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121757/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #28313:
URL: https://github.com/apache/spark/pull/28313#discussion_r413955942
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1674,9 +1676,21 @@ case class TruncDate(date: Expression, format: Expression)
@ExpressionDescription(
usage = """
_FUNC_(fmt, ts) - Returns timestamp `ts` truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["MILLENNIUM", "CENTURY", "DECADE", "YEAR", "YYYY", "YY",
- "QUARTER", "MON", "MONTH", "MM", "WEEK", "DAY", "DD",
- "HOUR", "MINUTE", "SECOND", "MILLISECOND", "MICROSECOND"]
+ """,
+ arguments = """
+ Arguments:
+ * fmt - the format representing the unit to be truncated to
+ - "YEAR", "YYYY", "YY"
Review comment:
yea, updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618532286
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618846096
Jenkins, retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618847527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618532286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618313818
**[Test build #121672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121672/testReport)** for PR 28313 at commit [`5bd7390`](https://github.com/apache/spark/commit/5bd739009f0666cc30af1ac784de290cf8143948).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-619165802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618841695
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121723/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618829595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618711394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618314577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618513336
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618463669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618710755
**[Test build #121693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121693/testReport)** for PR 28313 at commit [`84a9b21`](https://github.com/apache/spark/commit/84a9b213fbb1e5bdbf86096cd094e69ceb2aca21).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28313:
URL: https://github.com/apache/spark/pull/28313#discussion_r413933919
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1674,9 +1676,21 @@ case class TruncDate(date: Expression, format: Expression)
@ExpressionDescription(
usage = """
_FUNC_(fmt, ts) - Returns timestamp `ts` truncated to the unit specified by the format model `fmt`.
- `fmt` should be one of ["MILLENNIUM", "CENTURY", "DECADE", "YEAR", "YYYY", "YY",
- "QUARTER", "MON", "MONTH", "MM", "WEEK", "DAY", "DD",
- "HOUR", "MINUTE", "SECOND", "MILLISECOND", "MICROSECOND"]
+ """,
+ arguments = """
+ Arguments:
+ * fmt - the format representing the unit to be truncated to
+ - "YEAR", "YYYY", "YY"
Review comment:
can we follow the doc of `extract` and give a bit introduction of the fields here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618841622
**[Test build #121723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121723/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618973642
**[Test build #121757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121757/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618847527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618532297
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121691/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618974167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618831585
**[Test build #121723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121723/testReport)** for PR 28313 at commit [`0a8e9e9`](https://github.com/apache/spark/commit/0a8e9e939a6475f47a7c4fe6b478ad7ed552e6ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618463669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618941898
Jenkins, retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-619298908
Could you make a backporting PR to branch-3.0, @yaooqinn ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618841687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618829595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-619165802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618971524
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618532200
**[Test build #121691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121691/testReport)** for PR 28313 at commit [`d3777e8`](https://github.com/apache/spark/commit/d3777e864104abac173d6243dd9d5ff61d619884).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-619322435
thanks for merging and reviewing @dongjoon-hyun @cloud-fan, I will backport this to 3.0 ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618923054
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618512732
**[Test build #121691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121691/testReport)** for PR 28313 at commit [`d3777e8`](https://github.com/apache/spark/commit/d3777e864104abac173d6243dd9d5ff61d619884).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618512732
**[Test build #121691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121691/testReport)** for PR 28313 at commit [`d3777e8`](https://github.com/apache/spark/commit/d3777e864104abac173d6243dd9d5ff61d619884).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618462204
**[Test build #121672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121672/testReport)** for PR 28313 at commit [`5bd7390`](https://github.com/apache/spark/commit/5bd739009f0666cc30af1ac784de290cf8143948).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618314577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618841687
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618539945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618539350
**[Test build #121693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121693/testReport)** for PR 28313 at commit [`84a9b21`](https://github.com/apache/spark/commit/84a9b213fbb1e5bdbf86096cd094e69ceb2aca21).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28313: [SPARK-31528][SQL] Remove millennium, century, decade from trunc/date_trunc fucntions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28313:
URL: https://github.com/apache/spark/pull/28313#issuecomment-618711394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org