[GitHub] [kafka] showuon commented on a change in pull request #11242: [WIP] MINOR: POC for KIP-591: Add config to set default store impl class

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r757778305



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Materialized.java
##########
@@ -103,6 +110,21 @@ protected Materialized(final Materialized<K, V, S> materialized) {
         return new Materialized<>(storeName);
     }
 
+    /**
+     * Materialize a {@link StateStore} with the store implementation.
+     *
+     * @param storeImplementation  store implementation used to materialize the store
+     * alphanumerics, '.', '_' and '-'.
+     * @param <K>       key type of the store
+     * @param <V>       value type of the store
+     * @param <S>       type of the {@link StateStore}
+     * @return a new {@link Materialized} instance with the given storeName
+     */
+    public static <K, V, S extends StateStore> Materialized<K, V, S> as(final StoreImplementation storeImplementation) {

Review comment:
       The reason I added this method is because user can still override the default config via this method if they want. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org