You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/14 16:28:44 UTC

[GitHub] [lucenenet] rclabo commented on a diff in pull request #650: Remove NET45, NET451, NET452 Support & update website framework ver

rclabo commented on code in PR #650:
URL: https://github.com/apache/lucenenet/pull/650#discussion_r995936859


##########
Lucene.Net.sln:
##########
@@ -263,7 +263,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Lucene.Net.Tests.AllProject
 EndProject
 Project("{E24C65DC-7377-472B-9ABA-BC803B73C61A}") = "websites", "websites\", "{8988CDA4-8420-4BEE-869A-66825055EED2}"
 	ProjectSection(WebsiteProperties) = preProject
-		TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.0"
+		TargetFrameworkMoniker = ".NETFramework,Version%3Dv4.6.2"

Review Comment:
   Initially I thought the same thing but then resolved that that chasing the latest version doesn't make sense. Further, the solution produces Framework 4.6.2 assemblies and 4.6.2 is not yet depreciated, so I decided it made more sense to use 4.6.2 for the website project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org