You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/26 13:09:44 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1115: FINERACT-1022: Fixing ehcache 3
ptuomola opened a new pull request #1115:
URL: https://github.com/apache/fineract/pull/1115
## Description
ehcache was not working at all after it had been upgraded from v2 to v3. This fixes the config files, dependencies and other artifacts to fix this.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#issuecomment-650291621
@xurror how does this look to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#issuecomment-650570044
> @xurror how does this look to you?
I want to properly test this locally. I should be able to provide feedback in the next 24hrs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#issuecomment-651345096
> I want to properly test this locally. I should be able to provide feedback in the next 24hrs
@xurror any update re. this? We would love you to fully review this for FINERACT-1022. You can go ahead and merge this when you LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#issuecomment-651233482
@xurror did you get a chance to try this out - did it work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1115:
URL: https://github.com/apache/fineract/pull/1115#discussion_r446309384
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientAddressRepository.java
##########
@@ -27,8 +27,8 @@
public interface ClientAddressRepository extends JpaRepository<ClientAddress, Long>, JpaSpecificationExecutor<ClientAddress> {
@Query("SELECT clientAddress FROM ClientAddress clientAddress WHERE clientAddress.client.id = :clientId AND clientAddress.addressType = :addressType AND clientAddress.isActive = :isActive ")
- ClientAddress findByClientIdAndAddressTypeAndIsActive(@Param("clientId") final long clientId, final CodeValue addressType,
- @Param("isActive") final boolean isActive);
+ ClientAddress findByClientIdAndAddressTypeAndIsActive(@Param("clientId") final long clientId,
+ @Param("addressType") final CodeValue addressType, @Param("isActive") final boolean isActive);
Review comment:
hah, nice catch - looks like this was wrong (missing) in #1110 ?! I missed it! @kiran-vsm FYI...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1115: FINERACT-1022: Fixing ehcache 3
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1115:
URL: https://github.com/apache/fineract/pull/1115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org