You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Eric Barboni <sk...@apache.org> on 2021/10/26 09:13:06 UTC
[RELEASES] rat issue for 12.6
Hi folks,
Rat process is showing the following file
https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retriever/t
est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12
as unapproved.
Best Regards
Eric
Re: [RELEASES] rat issue for 12.6
Posted by Neil C Smith <ne...@apache.org>.
On Wed, 27 Oct 2021 at 19:23, Matthias Bläsing
<mb...@doppel-helix.eu> wrote:
> I had a look at rat, verify-libs-and-licenses and verify-all-libs-and-
> licenses. The latter is not really critical, but showed a few gray
> areas. Contrib in general should be ignored.
>
> This is my suggested fix (opened against delivery):
>
> https://github.com/apache/netbeans/pull/3276
>
> I think the description covers the changes pretty good, the only think
> not in the description is the clarification, that the changes to the
> contrib licenses are not to fix them, but to get them in a better
> shape.
Thanks, Matthias. Changes look good.
I'm still concerned why we're getting different behaviours in
different places (Jenkins vs locally / Travis), and why these weren't
picked up in the PR tests. Any ideas there?
Yes, contrib can be ignored for release purposes, although it's still
good to have it in order.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [RELEASES] rat issue for 12.6
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Mittwoch, dem 27.10.2021 um 12:15 +0100 schrieb Neil C Smith:
> On Tue, 26 Oct 2021 at 11:23, Neil C Smith <ne...@apache.org> wrote:
> > On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote:
> > > Rat process is showing the following file
> > >
> > > https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retriever/t
> > > est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12
> > >
> > > as unapproved.
> >
> > Curious! What exactly did you run? It passes here, and passed the
> > rat test in the PR that introduced it. Although it does show as B not
> > AL. It perhaps shouldn't pass?
>
> Firstly, thanks for fixing the NBI build. Looks like we have an RC1
> which I'm just testing.
>
> But we might have a RAT issue to solve before release here.
>
> Interestingly, comparing the saved RAT report on the build server with
> local, it seems this file is picked up as text rather than binary.
> That might be the cause of differences in results?
I had a look at rat, verify-libs-and-licenses and verify-all-libs-and-
licenses. The latter is not really critical, but showed a few gray
areas. Contrib in general should be ignored.
This is my suggested fix (opened against delivery):
https://github.com/apache/netbeans/pull/3276
I think the description covers the changes pretty good, the only think
not in the description is the clarification, that the changes to the
contrib licenses are not to fix them, but to get them in a better
shape.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [RELEASES] rat issue for 12.6
Posted by Neil C Smith <ne...@apache.org>.
On Tue, 26 Oct 2021 at 11:23, Neil C Smith <ne...@apache.org> wrote:
> On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote:
> > Rat process is showing the following file
> >
> > https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retriever/t
> > est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12
> >
> > as unapproved.
>
> Curious! What exactly did you run? It passes here, and passed the
> rat test in the PR that introduced it. Although it does show as B not
> AL. It perhaps shouldn't pass?
Firstly, thanks for fixing the NBI build. Looks like we have an RC1
which I'm just testing.
But we might have a RAT issue to solve before release here.
Interestingly, comparing the saved RAT report on the build server with
local, it seems this file is picked up as text rather than binary.
That might be the cause of differences in results?
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [RELEASES] rat issue for 12.6
Posted by Eric Bresie <eb...@gmail.com>.
2 Unknown Licenses
*****************************************************
Files with unapproved licenses:
/home/jenkins/jenkins-agent/workspace/Netbeans/netbeans-license/contrib/j2ee.jboss4/external/j2ee.jboss4-external-resources.txt
/home/jenkins/jenkins-agent/workspace/Netbeans/netbeans-license/ide/xml.retriever/test/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12
On Tue, Oct 26, 2021 at 6:49 AM Eric Barboni <Er...@irit.fr> wrote:
> I was just looking build result as it was orange.
>
>
> https://ci-builds.apache.org/blue/organizations/jenkins/Netbeans%2Fnetbeans-TLP%2Fnetbeans/detail/release126/5/pipeline
> test tab
>
> It's also reported in
>
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-license/lastCompletedBuild/
> alongside a long list of libs error I'm not sure what to do against.
>
> I'm puzzled why it's was not catch by travis.
>
> Eric
> -----Message d'origine-----
> De : Neil C Smith <ne...@apache.org>
> Envoyé : mardi 26 octobre 2021 12:23
> À : dev <de...@netbeans.apache.org>
> Objet : Re: [RELEASES] rat issue for 12.6
>
> Hi,
>
> On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote:
>
>
> > Rat process is showing the following file
> >
> > https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retri
> > ever/t
> > est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client
> > .p12
> >
> > as unapproved.
>
> Curious! What exactly did you run? It passes here, and passed the rat
> test in the PR that introduced it. Although it does show as B not AL. It
> perhaps shouldn't pass?
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
> --
Eric Bresie
ebresie@gmail.com
Re: [RELEASES] rat issue for 12.6
Posted by Neil C Smith <ne...@apache.org>.
On Tue, 26 Oct 2021 at 12:49, Eric Barboni <Er...@irit.fr> wrote:
> I was just looking build result as it was orange.
Yes, I noticed that and wasn't sure why. Looking at the error message
from the link you shared, maybe
https://github.com/jenkinsci/checks-api-plugin/issues/38 ?
> https://ci-builds.apache.org/blue/organizations/jenkins/Netbeans%2Fnetbeans-TLP%2Fnetbeans/detail/release126/5/pipeline
> test tab
OK, see that.
> It's also reported in
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-license/lastCompletedBuild/
> alongside a long list of libs error I'm not sure what to do against.
>
> I'm puzzled why it's was not catch by travis.
I don't know. I can pick up the jboss4 file but not the badssl one
locally, although I've also had the test pass locally. Think we need
to compare exact commands being run, environment, etc.?
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: [RELEASES] rat issue for 12.6
Posted by Eric Barboni <Er...@irit.fr>.
I was just looking build result as it was orange.
https://ci-builds.apache.org/blue/organizations/jenkins/Netbeans%2Fnetbeans-TLP%2Fnetbeans/detail/release126/5/pipeline
test tab
It's also reported in
https://ci-builds.apache.org/job/Netbeans/job/netbeans-license/lastCompletedBuild/
alongside a long list of libs error I'm not sure what to do against.
I'm puzzled why it's was not catch by travis.
Eric
-----Message d'origine-----
De : Neil C Smith <ne...@apache.org>
Envoyé : mardi 26 octobre 2021 12:23
À : dev <de...@netbeans.apache.org>
Objet : Re: [RELEASES] rat issue for 12.6
Hi,
On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote:
> Rat process is showing the following file
>
> https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retri
> ever/t
> est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client
> .p12
>
> as unapproved.
Curious! What exactly did you run? It passes here, and passed the rat test in the PR that introduced it. Although it does show as B not AL. It perhaps shouldn't pass?
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [RELEASES] rat issue for 12.6
Posted by Neil C Smith <ne...@apache.org>.
Hi,
On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote:
> Rat process is showing the following file
>
> https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retriever/t
> est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12
>
> as unapproved.
Curious! What exactly did you run? It passes here, and passed the
rat test in the PR that introduced it. Although it does show as B not
AL. It perhaps shouldn't pass?
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists