You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Hitoshi Ozawa (Created) (JIRA)" <ji...@apache.org> on 2012/01/09 14:14:39 UTC
[jira] [Created] (CONNECTORS-356) Active Directory connector should
by fully I18N/L10N
Active Directory connector should by fully I18N/L10N
----------------------------------------------------
Key: CONNECTORS-356
URL: https://issues.apache.org/jira/browse/CONNECTORS-356
Project: ManifoldCF
Issue Type: Improvement
Components: Active Directory authority
Affects Versions: ManifoldCF 0.5
Reporter: Hitoshi Ozawa
Priority: Minor
Fix For: ManifoldCF 0.5
All messages in Active Directory Connector should be extracted out to properties file.
Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright reassigned CONNECTORS-356:
--------------------------------------
Assignee: Karl Wright
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182796#comment-13182796 ]
Hitoshi Ozawa commented on CONNECTORS-356:
------------------------------------------
bq. For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future.
I thought you wanted a separate issue for each connector.
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182566#comment-13182566 ]
Karl Wright commented on CONNECTORS-356:
----------------------------------------
r1229212
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182917#comment-13182917 ]
Karl Wright commented on CONNECTORS-356:
----------------------------------------
bq. I thought you wanted a separate issue for each connector.
Separate issue, separate patch, but patch should be created so that it can be applied from the trunk directory, not somewhere deep in the hierarchy. You can create such a diff like this:
{code}
cd ~/mcf/trunk
svn diff connectors/xyz >CONNECTORS-123.patch
{code}
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-356) Active Directory connector should
by fully I18N/L10N
Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hitoshi Ozawa updated CONNECTORS-356:
-------------------------------------
Attachment: CONNECTORS-356.patch
Extract out all messages to properties file and add Japanese messages.
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karl Wright resolved CONNECTORS-356.
------------------------------------
Resolution: Fixed
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182488#comment-13182488 ]
Karl Wright commented on CONNECTORS-356:
----------------------------------------
For what it is worth, patches should always be rooted at trunk. I'll commit this, but please bear this in mind for the future.
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182928#comment-13182928 ]
Hitoshi Ozawa commented on CONNECTORS-356:
------------------------------------------
Got you. Will do from next time. :-)
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182492#comment-13182492 ]
Karl Wright commented on CONNECTORS-356:
----------------------------------------
I've looked at this patch. It embeds the Javascript etc. quotation marks right in the translation. I believe this to be bad practice since the localization is then based on the context in which it is used.
For example:
{code}
+" alert(" + Messages.getString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + ");\n"+
{code}
...combined with...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=\"Enter a domain controller server name\"
{code}
I think this should be:
{code}
+" alert(\"" + Messages.getJavascriptBodyString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + "\");\n"+
{code}
... and ...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=Enter a domain controller server name
{code}
Do you agree?
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-356) Active Directory connector
should by fully I18N/L10N
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182671#comment-13182671 ]
Karl Wright commented on CONNECTORS-356:
----------------------------------------
r1229277
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CONNECTORS-356) Active Directory
connector should by fully I18N/L10N
Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182492#comment-13182492 ]
Karl Wright edited comment on CONNECTORS-356 at 1/9/12 1:52 PM:
----------------------------------------------------------------
I've looked at this patch. It embeds the Javascript etc. quotation marks right in the translation. I believe this to be bad practice since the localization is then based on the context in which it is used.
For example:
{code}
+" alert(" + Messages.getString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + ");\n"+
{code}
...combined with...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=\"Enter a domain controller server name\"
{code}
I think this should be:
{code}
+" alert(\"" + Messages.getBodyJavascriptString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + "\");\n"+
{code}
... and ...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=Enter a domain controller server name
{code}
Do you agree?
was (Author: kwright@metacarta.com):
I've looked at this patch. It embeds the Javascript etc. quotation marks right in the translation. I believe this to be bad practice since the localization is then based on the context in which it is used.
For example:
{code}
+" alert(" + Messages.getString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + ");\n"+
{code}
...combined with...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=\"Enter a domain controller server name\"
{code}
I think this should be:
{code}
+" alert(\"" + Messages.getJavascriptBodyString(locale,"ActiveDirectoryAuthority.EnterADomainControllerServerName") + "\");\n"+
{code}
... and ...
{code}
+ActiveDirectoryAuthority.EnterADomainControllerServerName=Enter a domain controller server name
{code}
Do you agree?
> Active Directory connector should by fully I18N/L10N
> ----------------------------------------------------
>
> Key: CONNECTORS-356
> URL: https://issues.apache.org/jira/browse/CONNECTORS-356
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Affects Versions: ManifoldCF 0.5
> Reporter: Hitoshi Ozawa
> Assignee: Karl Wright
> Priority: Minor
> Labels: I18N
> Fix For: ManifoldCF 0.5
>
> Attachments: CONNECTORS-356.patch
>
>
> All messages in Active Directory Connector should be extracted out to properties file.
> Also, should create Japanese L10N properties file for all messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira