You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:47:23 UTC
[GitHub] [maven] cstamas opened a new pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken
cstamas opened a new pull request #479:
URL: https://github.com/apache/maven/pull/479
It is broken since 3.6.2 or so, when ModelBuilder got decorated with
JSR330 injections, that work in sisu but not in Guice as it needs
explicit bindings added.
This is an UT that proves that module is incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #479:
URL: https://github.com/apache/maven/pull/479#issuecomment-917684076
Related: after https://issues.apache.org/jira/browse/MNG-6685 the Guice module was not updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #479:
URL: https://github.com/apache/maven/pull/479#issuecomment-860515450
As expected, newly added UT fails:
```
Error: Errors:
Error: MavenResolverModuleTest.smokeTest:31 ยป Creation Unable to create injector, see...
[INFO]
Error: Tests run: 28, Failures: 0, Errors: 1, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken
Posted by GitBox <gi...@apache.org>.
cstamas commented on pull request #479:
URL: https://github.com/apache/maven/pull/479#issuecomment-944506272
Test will pass, but not done yet: module is getting huge, so probably needs some refactoring, maybe splitting them into several parts (and allow overrides).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org