You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2008/03/14 11:41:24 UTC

[jira] Created: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Eclipse plugin fails to compile due to missing RPC.stopClient() method
----------------------------------------------------------------------

                 Key: HADOOP-3018
                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
             Project: Hadoop Core
          Issue Type: Bug
          Components: contrib/eclipse-plugin
            Reporter: Tom White


HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Tom White (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-3018:
------------------------------

    Fix Version/s: 0.17.0
         Priority: Blocker  (was: Major)

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Taton reassigned HADOOP-3018:
----------------------------------------

    Assignee: Christophe Taton

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Taton updated HADOOP-3018:
-------------------------------------

    Status: Patch Available  (was: Open)

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586575#action_12586575 ] 

Nigel Daley commented on HADOOP-3018:
-------------------------------------

Running thru Hudson now.  Can you commit if it's successful?

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586697#action_12586697 ] 

Hudson commented on HADOOP-3018:
--------------------------------

Integrated in Hadoop-branch #5 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-branch/5/])

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586756#action_12586756 ] 

Hudson commented on HADOOP-3018:
--------------------------------

Integrated in Hadoop-trunk #454 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/454/])

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585420#action_12585420 ] 

Christophe Taton commented on HADOOP-3018:
------------------------------------------

Yes, I'll post one soon (this week-end).

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "lohit vijayarenu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

lohit vijayarenu updated HADOOP-3018:
-------------------------------------

    Attachment: HADOOP-3018.patch

eclipse build also failed due to HADOOP-2563. For the problem reported in this JIRA RPC.stopClient() has been make private which gets called automatically once reference count reaches zero. I see that the thread already calls FileSystem.closeAll() which should be good.

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Taton updated HADOOP-3018:
-------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

There are no tests for the eclipse plug-in.
I just committed this. Thanks!

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Mukund Madhugiri (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585353#action_12585353 ] 

Mukund Madhugiri commented on HADOOP-3018:
------------------------------------------

Will there be a patch for 0.17.0?

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586630#action_12586630 ] 

Hadoop QA commented on HADOOP-3018:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12379473/3018-20080405a.patch
against trunk revision 643282.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2178/console

This message is automatically generated.

> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3018) Eclipse plugin fails to compile due to missing RPC.stopClient() method

Posted by "Christophe Taton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Taton updated HADOOP-3018:
-------------------------------------

    Attachment: 3018-20080405a.patch

3018-20080405a.patch adds a couple of other small cleanups: removes a deprecated call to fs.delete, also removes a some duplicated code.

In fact, calling FileSystem.closeAll() seems not to be powerful enough but that's all what we can do for now.
The RPC has not been designed for such a use as the one we have in the Eclipse plug-in, and if someone enters a wrong configuration or has some networking issues (firewall, etc), the UI might appear dead or unresponsive.


> Eclipse plugin fails to compile due to missing RPC.stopClient() method
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-3018
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3018
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/eclipse-plugin
>            Reporter: Tom White
>            Assignee: Christophe Taton
>            Priority: Blocker
>             Fix For: 0.17.0
>
>         Attachments: 3018-20080405a.patch, HADOOP-3018.patch
>
>
> HADOOP-2870 removed the RPC.stopClient() method which is called by org.apache.hadoop.eclipse.dfs.DFSLocationsRoot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.