[jira] [Created] (CALCITE-1264) Litmus fail does not interpolate arguments

["Chris Baynes (JIRA)" <ji...@apache.org>]

Chris Baynes created CALCITE-1264:
-------------------------------------

             Summary: Litmus fail does not interpolate arguments
                 Key: CALCITE-1264
                 URL: https://issues.apache.org/jira/browse/CALCITE-1264
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: Chris Baynes
            Assignee: Julian Hyde


Litmus#fail is currently implemented with String.format which does not accept a pair of curly brackets '{}' for formatting variables. 
For example,

litmus.fail("msg is {}", "some error");
 => "msg is {}"

I see 2 options:

1. Change every call to fail that uses {}
2. fail should use the sl4j MessageFormatter

I'm going to open a PR with strategy 2. It's nice to keep the same message format as the logger, otherwise it's easy to introduce bugs there. There are currently only 2 places that use the "%s" format to call fail, so those can be easily changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)