You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/03 00:39:28 UTC

[GitHub] [druid] suneet-s opened a new pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

suneet-s opened a new pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606
 
 
   Backports the following commits to 0.18.0:
    - DruidInputSource can add new dimensions during re-ingestion (#9590)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
suneet-s commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#issuecomment-608239622
 
 
   > Looks like you have COMPILATION ERROR from QUICKSTART_COMPATIBLE that was added in master
   > Suggest removing the QUICKSTART_COMPATIBLE group
   
   👍 thanks for pointing that out

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on a change in pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#discussion_r402745873
 
 

 ##########
 File path: integration-tests/src/test/java/org/apache/druid/tests/indexer/ITTransformTest.java
 ##########
 @@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.tests.indexer;
+
+import org.apache.druid.testing.guice.DruidTestModuleFactory;
+import org.apache.druid.tests.TestNGGroup;
+import org.testng.annotations.Guice;
+import org.testng.annotations.Test;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+@Test(groups = {TestNGGroup.BATCH_INDEX, TestNGGroup.QUICKSTART_COMPATIBLE})
 
 Review comment:
   ```suggestion
   @Test(groups = TestNGGroup.BATCH_INDEX)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] maytasm removed a comment on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
maytasm removed a comment on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#issuecomment-608236371
 
 
   Looks like you have COMPILATION ERROR from QUICKSTART_COMPATIBLE that was added in master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
suneet-s commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#issuecomment-608169853
 
 
   clean backport

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on a change in pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#discussion_r402745873
 
 

 ##########
 File path: integration-tests/src/test/java/org/apache/druid/tests/indexer/ITTransformTest.java
 ##########
 @@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.tests.indexer;
+
+import org.apache.druid.testing.guice.DruidTestModuleFactory;
+import org.apache.druid.tests.TestNGGroup;
+import org.testng.annotations.Guice;
+import org.testng.annotations.Test;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+@Test(groups = {TestNGGroup.BATCH_INDEX, TestNGGroup.QUICKSTART_COMPATIBLE})
 
 Review comment:
   ```suggestion
   @Test(groups = {TestNGGroup.BATCH_INDEX})
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] maytasm commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
maytasm commented on issue #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606#issuecomment-608236371
 
 
   Looks like you have COMPILATION ERROR from QUICKSTART_COMPATIBLE that was added in master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] jihoonson merged pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)

Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9606: [0.18.0] DruidInputSource can add new dimensions during re-ingestion (#9590)
URL: https://github.com/apache/druid/pull/9606
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org