[GitHub] [airflow] potiuk commented on a diff in pull request #25306: Add pre-release limits when constructing devel-all

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #25306:
URL: https://github.com/apache/airflow/pull/25306#discussion_r932061081


##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -314,7 +314,20 @@ def get_install_requirements(provider_package_id: str, version_suffix: str) -> s
 
     :return: install requirements of the package
     """
-    install_requires = ALL_DEPENDENCIES[provider_package_id][DEPS]
+
+    def apply_version_suffix(install_clause: str) -> str:
+        if install_clause.startswith("apache-airflow") and ">=" in install_clause and version_suffix != "":
+            # This is workaround for `pip` bug. When you specify dependency as >= X.Y.Z, and you
+            # Have packages X.Y.Zdev0 or X.Y.Zrc1, the "=" part does not include the pre-release versions
+            # you need to explicitly specify >= X.Y.Za0 to include pre-release versions.
+            # Therefore, when we are preparing pre-releases we always add a0 for airflow and other providers
+            # to Allow installing two packages released in rc* that depend on each-other

Review Comment:
   Yeah. That woudl explain it. Just checked it and indeed - simply replacing the suffix with the one we are just building with is good. Update coming in a minute.
   
   So really the problem (might not be a "bug" ) with `pip` is that `--pre` does not apply to limit of the dependecies of the packages you are installing - just to the packages that you are installing. Would that be the right "assesment" ?
   
   Do you think is it something that could be changed easiy and accepted? Maybe I could even attempt to find and fix it, but I am a little bit sceptical after the rejections (and the form of those rejections especially) I got before, so I am a little bit sceptical about submitting anything like that without knowing if it is something that maybe has been discussed in the past or maybe there is a long discussion somewhere I am not aware of.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org