[GitHub] [iotdb] HTHou commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579607672



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
     if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
       throw new IllegalPathException(prefixPath.getFullPath());
     }
+    Holder<Integer> countHolder = new Holder<>(0);
     try {
-      return getCount(root, nodes, 1);
+      getAllTimeseriesCountHelper(root, nodes, 1, countHolder, false);

Review comment:
       I feel the method name `getAllTimeseriesCountHelper` is not clear enough. How about just keep the origin method name `getCount`?

##########
File path: server/src/main/java/org/apache/iotdb/db/utils/Holder.java
##########
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * <p>http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * <p>Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing permissions and
+ * limitations under the License.
+ */

Review comment:
       ```suggestion
   /*
    * Licensed to the Apache Software Foundation (ASF) under one
    * or more contributor license agreements.  See the NOTICE file
    * distributed with this work for additional information
    * regarding copyright ownership.  The ASF licenses this file
    * to you under the Apache License, Version 2.0 (the
    * "License"); you may not use this file except in compliance
    * with the License.  You may obtain a copy of the License at
    *
    *     http://www.apache.org/licenses/LICENSE-2.0
    *
    * Unless required by applicable law or agreed to in writing,
    * software distributed under the License is distributed on an
    * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    * KIND, either express or implied.  See the License for the
    * specific language governing permissions and limitations
    * under the License.
    */
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org