You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Zheng, Kai" <ka...@intel.com> on 2015/01/15 07:20:34 UTC
[Kerby/Haox] About committing codes for contributors
Hi all,
I helped commit patches from contributors with specific comment format borrowing the practice from other Apache project. Below are examples. I'm wondering if it's good or not here. Please help clarify, thanks.
===
commit 40deb1dfcf47525b2f162d2ddda18e36141393cb
Author: Drankye <dr...@gmail.com>
Date: Tue Jan 13 15:17:39 2015 +0800
DIRKRB-138 Adding Apache License for non-code files. Contributed by Lin Chen
commit 05699afeddb323e623001b9add8784669f739cae
Author: Drankye <dr...@gmail.com>
Date: Tue Jan 13 11:36:49 2015 +0800
DIRKRB-133 Added apache license header. Contributed by Lin Chen
===
Regards,
Kai
RE: [Kerby/Haox] About committing codes for contributors
Posted by "Zheng, Kai" <ka...@intel.com>.
Hi Pierre,
Yes I’m able to do so thanks for Emmanuel’s hardwork and fixup some days ago. I’m not complaining for myself, but querying for new contributors (not committers).
Regards,
Kai
From: Pierre Smits [mailto:pierre.smits@gmail.com]
Sent: Thursday, January 15, 2015 9:39 PM
To: Apache Directory Developers List
Subject: Re: [Kerby/Haox] About committing codes for contributors
I believe all committers must be able to assign issues to themselves and have the ability to augment (if needed) and close these issues when resolved.
Best regards,
Pierre Smits
ORRTIZ.COM<http://www.orrtiz.com>
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com<http://www.orrtiz.com/>
On Thu, Jan 15, 2015 at 2:10 PM, Zheng, Kai <ka...@intel.com>> wrote:
>> no worries, this is acceptable
Thanks Kiran for the confirm. Do we have a consistent model regarding this?
By the way, is it possible to assign issues to a new contributor as other Apache project allows? Not only for being easier to track, but also AFAIK some contributors would like them to be assigned when work on the issues.
Regards,
Kai
From: Kiran Ayyagari [mailto:kayyagari@apache.org<ma...@apache.org>]
Sent: Thursday, January 15, 2015 2:24 PM
To: Apache Directory Developers List
Subject: Re: [Kerby/Haox] About committing codes for contributors
On Thu, Jan 15, 2015 at 2:20 PM, Zheng, Kai <ka...@intel.com>> wrote:
Hi all,
I helped commit patches from contributors with specific comment format borrowing the practice from other Apache project. Below are examples. I’m wondering if it’s good or not here. Please help clarify, thanks.
no worries, this is acceptable
===
commit 40deb1dfcf47525b2f162d2ddda18e36141393cb
Author: Drankye <dr...@gmail.com>>
Date: Tue Jan 13 15:17:39 2015 +0800
DIRKRB-138 Adding Apache License for non-code files. Contributed by Lin Chen
commit 05699afeddb323e623001b9add8784669f739cae
Author: Drankye <dr...@gmail.com>>
Date: Tue Jan 13 11:36:49 2015 +0800
DIRKRB-133 Added apache license header. Contributed by Lin Chen
===
Regards,
Kai
--
Kiran Ayyagari
http://keydap.com
RE: [Kerby/Haox] About committing codes for contributors
Posted by "Zheng, Kai" <ka...@intel.com>.
Hi Pierre,
>> I must confess that I have limited experiences, so I might be mistaken.
Me too. I’m also working on Hadoop related projects and the experience is, once somebody is explicitly added into the contributors list as we just did for Lin, he/she can assign any issue to him/her-self, by simply clicking “Assign to me”. Sometimes (not rarely) it’s bad but in that case committers will find that and then get it corrected. Looks like our project isn’t so much leveraging JIRA system than Hadoop projects do, thus I would think either way would work for us.
Regards,
Kai
From: Pierre Smits [mailto:pierre.smits@gmail.com]
Sent: Friday, January 16, 2015 3:10 PM
To: Apache Directory Developers List
Subject: Re: [Kerby/Haox] About committing codes for contributors
I believe that the general consensus within the greater ASF community is that non-committing contributors can't assign issues to themselves, but still can work on their own issues (changing specific fields, including closing the issue), and that committers can. But, I must confess that I have limited experiences, so I might be mistaken.
If we want them to be able to reassign (and be able to execute other actions not associated with the role) , we should consider inviting them to be committers. In general I say: the more the better for the project and its works.
Best regards,
Pierre Smits
ORRTIZ.COM<http://www.orrtiz.com>
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com<http://www.orrtiz.com/>
On Fri, Jan 16, 2015 at 5:25 AM, Emmanuel Lécharny <el...@gmail.com>> wrote:
Le 16/01/15 03:43, Zheng, Kai a écrit :
> Oh, I see. We need extra step to add somebody in the contributors list so that he/she can be picked up in the possible assignee list in the JIRA.
>
> I noticed Lin Chen was able to assign issues to herself today. That makes sense because it looks like she would continuously work on the project (quite a few patches already).
>
> For new contributors, perhaps we would use the similar approach, say if he/she has already come up more than 3 patches, then we could ..., make sense?
For JIRA contributors, we should add them to the list of contributors no
matter what.
Re: [Kerby/Haox] About committing codes for contributors
Posted by Pierre Smits <pi...@gmail.com>.
I believe that the general consensus within the greater ASF community is
that non-committing contributors can't assign issues to themselves, but
still can work on their own issues (changing specific fields, including
closing the issue), and that committers can. But, I must confess that I
have limited experiences, so I might be mistaken.
If we want them to be able to reassign (and be able to execute other
actions not associated with the role) , we should consider inviting them to
be committers. In general I say: the more the better for the project and
its works.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Fri, Jan 16, 2015 at 5:25 AM, Emmanuel Lécharny <el...@gmail.com>
wrote:
> Le 16/01/15 03:43, Zheng, Kai a écrit :
> > Oh, I see. We need extra step to add somebody in the contributors list
> so that he/she can be picked up in the possible assignee list in the JIRA.
> >
> > I noticed Lin Chen was able to assign issues to herself today. That
> makes sense because it looks like she would continuously work on the
> project (quite a few patches already).
> >
> > For new contributors, perhaps we would use the similar approach, say if
> he/she has already come up more than 3 patches, then we could ..., make
> sense?
>
> For JIRA contributors, we should add them to the list of contributors no
> matter what.
>
>
Re: [Kerby/Haox] About committing codes for contributors
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 16/01/15 03:43, Zheng, Kai a écrit :
> Oh, I see. We need extra step to add somebody in the contributors list so that he/she can be picked up in the possible assignee list in the JIRA.
>
> I noticed Lin Chen was able to assign issues to herself today. That makes sense because it looks like she would continuously work on the project (quite a few patches already).
>
> For new contributors, perhaps we would use the similar approach, say if he/she has already come up more than 3 patches, then we could ..., make sense?
For JIRA contributors, we should add them to the list of contributors no
matter what.
RE: [Kerby/Haox] About committing codes for contributors
Posted by "Zheng, Kai" <ka...@intel.com>.
Oh, I see. We need extra step to add somebody in the contributors list so that he/she can be picked up in the possible assignee list in the JIRA.
I noticed Lin Chen was able to assign issues to herself today. That makes sense because it looks like she would continuously work on the project (quite a few patches already).
For new contributors, perhaps we would use the similar approach, say if he/she has already come up more than 3 patches, then we could ..., make sense?
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Thursday, January 15, 2015 9:54 PM
To: Apache Directory Developers List
Subject: Re: [Kerby/Haox] About committing codes for contributors
Le 15/01/15 14:39, Pierre Smits a écrit :
> I believe all committers must be able to assign issues to themselves
> and have the ability to augment (if needed) and close these issues
> when resolved.
So let me clarify some few things :
We do have committers, people being voted in. Those who participate and which we consider as valuable contributors should be quickly made committers.
We also have contributors : those who have not *yet* been voted in as committers, or people who just post one patch and never come back.
In any case, from the JIRA POV, this distinction is irrelevant : the assigned roles - and the associated permissions - are driven by other criteria. Typically, in order to be able to assign an issue to yourself, you have to have the 'contributors' role, and this is something we have to do manually in JIRA (and only admin for the project can do that).
Yes, I know, it's stupid...
So please give me the list of contributors (with their JIRA name) so that I can add them to the 'contributors' role.
Thanks !
Re: [Kerby/Haox] About committing codes for contributors
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 15/01/15 14:39, Pierre Smits a écrit :
> I believe all committers must be able to assign issues to themselves and
> have the ability to augment (if needed) and close these issues when
> resolved.
So let me clarify some few things :
We do have committers, people being voted in. Those who participate and
which we consider as valuable contributors should be quickly made
committers.
We also have contributors : those who have not *yet* been voted in as
committers, or people who just post one patch and never come back.
In any case, from the JIRA POV, this distinction is irrelevant : the
assigned roles - and the associated permissions - are driven by other
criteria. Typically, in order to be able to assign an issue to yourself,
you have to have the 'contributors' role, and this is something we have
to do manually in JIRA (and only admin for the project can do that).
Yes, I know, it's stupid...
So please give me the list of contributors (with their JIRA name) so
that I can add them to the 'contributors' role.
Thanks !
Re: [Kerby/Haox] About committing codes for contributors
Posted by Pierre Smits <pi...@gmail.com>.
I believe all committers must be able to assign issues to themselves and
have the ability to augment (if needed) and close these issues when
resolved.
Best regards,
Pierre Smits
*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com
On Thu, Jan 15, 2015 at 2:10 PM, Zheng, Kai <ka...@intel.com> wrote:
> >> no worries, this is acceptable
>
> Thanks Kiran for the confirm. Do we have a consistent model regarding this?
>
>
>
> By the way, is it possible to assign issues to a new contributor as other
> Apache project allows? Not only for being easier to track, but also AFAIK
> some contributors would like them to be assigned when work on the issues.
>
>
>
> Regards,
>
> Kai
>
>
>
> *From:* Kiran Ayyagari [mailto:kayyagari@apache.org]
> *Sent:* Thursday, January 15, 2015 2:24 PM
> *To:* Apache Directory Developers List
> *Subject:* Re: [Kerby/Haox] About committing codes for contributors
>
>
>
>
>
>
>
> On Thu, Jan 15, 2015 at 2:20 PM, Zheng, Kai <ka...@intel.com> wrote:
>
> Hi all,
>
>
>
> I helped commit patches from contributors with specific comment format
> borrowing the practice from other Apache project. Below are examples. I’m
> wondering if it’s good or not here. Please help clarify, thanks.
>
>
>
> no worries, this is acceptable
>
> ===
>
> commit 40deb1dfcf47525b2f162d2ddda18e36141393cb
>
> Author: Drankye <dr...@gmail.com>
>
> Date: Tue Jan 13 15:17:39 2015 +0800
>
>
>
> DIRKRB-138 Adding Apache License for non-code files. Contributed by
> Lin Chen
>
>
>
> commit 05699afeddb323e623001b9add8784669f739cae
>
> Author: Drankye <dr...@gmail.com>
>
> Date: Tue Jan 13 11:36:49 2015 +0800
>
>
>
> DIRKRB-133 Added apache license header. Contributed by Lin Chen
>
>
>
> ===
>
>
>
> Regards,
>
> Kai
>
>
>
>
> --
>
> Kiran Ayyagari
> http://keydap.com
>
RE: [Kerby/Haox] About committing codes for contributors
Posted by "Zheng, Kai" <ka...@intel.com>.
>> no worries, this is acceptable
Thanks Kiran for the confirm. Do we have a consistent model regarding this?
By the way, is it possible to assign issues to a new contributor as other Apache project allows? Not only for being easier to track, but also AFAIK some contributors would like them to be assigned when work on the issues.
Regards,
Kai
From: Kiran Ayyagari [mailto:kayyagari@apache.org]
Sent: Thursday, January 15, 2015 2:24 PM
To: Apache Directory Developers List
Subject: Re: [Kerby/Haox] About committing codes for contributors
On Thu, Jan 15, 2015 at 2:20 PM, Zheng, Kai <ka...@intel.com>> wrote:
Hi all,
I helped commit patches from contributors with specific comment format borrowing the practice from other Apache project. Below are examples. I’m wondering if it’s good or not here. Please help clarify, thanks.
no worries, this is acceptable
===
commit 40deb1dfcf47525b2f162d2ddda18e36141393cb
Author: Drankye <dr...@gmail.com>>
Date: Tue Jan 13 15:17:39 2015 +0800
DIRKRB-138 Adding Apache License for non-code files. Contributed by Lin Chen
commit 05699afeddb323e623001b9add8784669f739cae
Author: Drankye <dr...@gmail.com>>
Date: Tue Jan 13 11:36:49 2015 +0800
DIRKRB-133 Added apache license header. Contributed by Lin Chen
===
Regards,
Kai
--
Kiran Ayyagari
http://keydap.com
Re: [Kerby/Haox] About committing codes for contributors
Posted by Kiran Ayyagari <ka...@apache.org>.
On Thu, Jan 15, 2015 at 2:20 PM, Zheng, Kai <ka...@intel.com> wrote:
> Hi all,
>
>
>
> I helped commit patches from contributors with specific comment format
> borrowing the practice from other Apache project. Below are examples. I’m
> wondering if it’s good or not here. Please help clarify, thanks.
>
>
>
no worries, this is acceptable
> ===
>
> commit 40deb1dfcf47525b2f162d2ddda18e36141393cb
>
> Author: Drankye <dr...@gmail.com>
>
> Date: Tue Jan 13 15:17:39 2015 +0800
>
>
>
> DIRKRB-138 Adding Apache License for non-code files. Contributed by
> Lin Chen
>
>
>
> commit 05699afeddb323e623001b9add8784669f739cae
>
> Author: Drankye <dr...@gmail.com>
>
> Date: Tue Jan 13 11:36:49 2015 +0800
>
>
>
> DIRKRB-133 Added apache license header. Contributed by Lin Chen
>
>
>
> ===
>
>
>
> Regards,
>
> Kai
>
--
Kiran Ayyagari
http://keydap.com