You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Scott Inglis <ms...@gmail.com> on 2018/03/15 21:15:25 UTC
C# VS 2017 Project Migration
Hello,
With the last change to the DotNet projects, we should now have the ability
to switch to using the new projects.
As part of the transition, my thoughts are to:
1) Switch AppVeyor to use target the new projects. (JIRA-1990
https://issues.apache.org/jira/browse/REEF-1990)
2) Delete the old projects, rename the new projects to the name of the old
projects (effectively removing the "DotNet" name on everything).
(JIRA-1991 https://issues.apache.org/jira/browse/REEF-1991)
3) Remove any remaining build files. (also part of JIRA-1991)
I can start this today -- are there any concerns or questions regarding
these changes?
Thanks,
Scott
Re: C# VS 2017 Project Migration
Posted by Byung-Gon Chun <bg...@gmail.com>.
Hi Scott,
Thank you for sharing the .Net project update!
Looking forward to .netcore 2.0.
Thanks.
-Gon
On Sat, Mar 17, 2018 at 1:31 AM, Scott Inglis <ms...@gmail.com> wrote:
> Gon --
>
> All existing projects have a corresponding .DotNet project that targets
> .net 452 -- this is meant to get to parity with what we currently have with
> the older projects. I have a switch in the build settings that does enable
> a .netcore build. When this switch is active, it will build .net45 and
> .netcore 2.0 but this is not a functioning build as there is work that
> needs to be done with the bridge. I have also discovered other issues
> related to .netcore (like how do we handle runtime executables (windows vs
> linux)?) that I will bring up to the forum and create JIRAs to address.
>
> With what is there now, we now have the ability to restore nuget packages,
> build and test .net 452 binaries using the new projects from the command
> line and in Visual Studio. I will post an update to my plan as for the
> migration as I have found some other issues that need to be addressed.
>
>
>
> On Thu, Mar 15, 2018 at 3:50 PM, Markus Weimer <ma...@weimo.de> wrote:
>
> > On Thu, Mar 15, 2018 at 2:15 PM, Scott Inglis <ms...@gmail.com>
> wrote:
> >
> > > I can start this today -- are there any concerns or questions regarding
> > > these changes?
> > >
> >
> > I don't seem to be able to build REEF using the new solution file:
> >
> > Invalid Resx file. Could not find file
> > 'C:\src\reef\lang\cs\bin\.netcore\Debug\Org.Apache.REEF.
> > Bridge\Org.Apache.REEF.Bridge.exe'.
> > Line 79, position 5.
> > C:\src\reef\lang\cs\Org.Apache.REEF.Client\Resources.DotNet.resx
> >
> > Any idea why that might be?
> >
> > Thanks,
> >
> > Markus
> >
>
--
Byung-Gon Chun
Re: C# VS 2017 Project Migration
Posted by Scott Inglis <ms...@gmail.com>.
Ok, I have PR for review here that fixes the build dependency and also
supports packing to nuget files. This is located here:
https://github.com/apache/reef/pull/1436
After this is committed, I can then start on the plan to switch AppVeyor to
the project files.
On Fri, Mar 16, 2018 at 1:24 PM, Scott Inglis <ms...@gmail.com> wrote:
> Its a build dependency. I have it fixed and tracking it under this JIRA:
> https://issues.apache.org/jira/browse/REEF-1993
>
> On Fri, Mar 16, 2018 at 11:45 AM, Markus Weimer <ma...@weimo.de> wrote:
>
>> > Are you building in VS or from the command line? If VS, can you try to
>> build the bridge first, then build the solution?
>>
>> This seems to have done the trick, thanks!
>>
>> This looks like a build dependency or order issue?
>>
>>
>> Thanks,
>>
>> Markus
>>
>
>
Re: C# VS 2017 Project Migration
Posted by Scott Inglis <ms...@gmail.com>.
Just an update on this plan:
1) Switch AppVeyor to use target the new projects. (JIRA-1990
https://issues.apache.org/jira/browse/REEF-1990)
2) Delete the old projects, rename the new projects to the name of the old
projects (effectively removing the "DotNet" name on everything).
(JIRA-1991 https://issues.apache.org/jira/browse/REEF-1991)
3) Remove any remaining build files. (also part of JIRA-1991)
Step 1 is now complete and this PR was merged:
https://issues.apache.org/jira/browse/REEF-1990
We are officially now building with the *.DotNet projects! So any new
project changes, please be sure to use the DotNet projects as the regular
projects will be deleted. I'm also happy to answer any questions or address
any issues.
Thanks,
Scott
On Fri, Mar 16, 2018 at 6:17 PM, Markus Weimer <ma...@weimo.de> wrote:
> Thanks! I will test that fix and merge it. -- Markus
>
> On Fri, Mar 16, 2018 at 1:24 PM, Scott Inglis <ms...@gmail.com> wrote:
>
> > Its a build dependency. I have it fixed and tracking it under this JIRA:
> > https://issues.apache.org/jira/browse/REEF-1993
> >
> > On Fri, Mar 16, 2018 at 11:45 AM, Markus Weimer <ma...@weimo.de> wrote:
> >
> > > > Are you building in VS or from the command line? If VS, can you try
> to
> > > build the bridge first, then build the solution?
> > >
> > > This seems to have done the trick, thanks!
> > >
> > > This looks like a build dependency or order issue?
> > >
> > >
> > > Thanks,
> > >
> > > Markus
> > >
> >
>
Re: C# VS 2017 Project Migration
Posted by Markus Weimer <ma...@weimo.de>.
Thanks! I will test that fix and merge it. -- Markus
On Fri, Mar 16, 2018 at 1:24 PM, Scott Inglis <ms...@gmail.com> wrote:
> Its a build dependency. I have it fixed and tracking it under this JIRA:
> https://issues.apache.org/jira/browse/REEF-1993
>
> On Fri, Mar 16, 2018 at 11:45 AM, Markus Weimer <ma...@weimo.de> wrote:
>
> > > Are you building in VS or from the command line? If VS, can you try to
> > build the bridge first, then build the solution?
> >
> > This seems to have done the trick, thanks!
> >
> > This looks like a build dependency or order issue?
> >
> >
> > Thanks,
> >
> > Markus
> >
>
Re: C# VS 2017 Project Migration
Posted by Scott Inglis <ms...@gmail.com>.
Its a build dependency. I have it fixed and tracking it under this JIRA:
https://issues.apache.org/jira/browse/REEF-1993
On Fri, Mar 16, 2018 at 11:45 AM, Markus Weimer <ma...@weimo.de> wrote:
> > Are you building in VS or from the command line? If VS, can you try to
> build the bridge first, then build the solution?
>
> This seems to have done the trick, thanks!
>
> This looks like a build dependency or order issue?
>
>
> Thanks,
>
> Markus
>
Re: C# VS 2017 Project Migration
Posted by Markus Weimer <ma...@weimo.de>.
> Are you building in VS or from the command line? If VS, can you try to
build the bridge first, then build the solution?
This seems to have done the trick, thanks!
This looks like a build dependency or order issue?
Thanks,
Markus
Re: C# VS 2017 Project Migration
Posted by Scott Inglis <ms...@gmail.com>.
Markus -
Are you building in VS or from the command line? If VS, can you try to
build the bridge first, then build the solution?
There is a bug in the VS build, but the command line should work. I will
create a JIRA to fix this bug and will need it resolved before switching.
On Fri, Mar 16, 2018 at 9:31 AM, Scott Inglis <ms...@gmail.com> wrote:
> Gon --
>
> All existing projects have a corresponding .DotNet project that targets
> .net 452 -- this is meant to get to parity with what we currently have with
> the older projects. I have a switch in the build settings that does enable
> a .netcore build. When this switch is active, it will build .net45 and
> .netcore 2.0 but this is not a functioning build as there is work that
> needs to be done with the bridge. I have also discovered other issues
> related to .netcore (like how do we handle runtime executables (windows vs
> linux)?) that I will bring up to the forum and create JIRAs to address.
>
> With what is there now, we now have the ability to restore nuget packages,
> build and test .net 452 binaries using the new projects from the command
> line and in Visual Studio. I will post an update to my plan as for the
> migration as I have found some other issues that need to be addressed.
>
>
>
> On Thu, Mar 15, 2018 at 3:50 PM, Markus Weimer <ma...@weimo.de> wrote:
>
>> On Thu, Mar 15, 2018 at 2:15 PM, Scott Inglis <ms...@gmail.com> wrote:
>>
>> > I can start this today -- are there any concerns or questions regarding
>> > these changes?
>> >
>>
>> I don't seem to be able to build REEF using the new solution file:
>>
>> Invalid Resx file. Could not find file
>> 'C:\src\reef\lang\cs\bin\.netcore\Debug\Org.Apache.REEF.Brid
>> ge\Org.Apache.REEF.Bridge.exe'.
>> Line 79, position 5.
>> C:\src\reef\lang\cs\Org.Apache.REEF.Client\Resources.DotNet.resx
>>
>> Any idea why that might be?
>>
>> Thanks,
>>
>> Markus
>>
>
>
Re: C# VS 2017 Project Migration
Posted by Scott Inglis <ms...@gmail.com>.
Gon --
All existing projects have a corresponding .DotNet project that targets
.net 452 -- this is meant to get to parity with what we currently have with
the older projects. I have a switch in the build settings that does enable
a .netcore build. When this switch is active, it will build .net45 and
.netcore 2.0 but this is not a functioning build as there is work that
needs to be done with the bridge. I have also discovered other issues
related to .netcore (like how do we handle runtime executables (windows vs
linux)?) that I will bring up to the forum and create JIRAs to address.
With what is there now, we now have the ability to restore nuget packages,
build and test .net 452 binaries using the new projects from the command
line and in Visual Studio. I will post an update to my plan as for the
migration as I have found some other issues that need to be addressed.
On Thu, Mar 15, 2018 at 3:50 PM, Markus Weimer <ma...@weimo.de> wrote:
> On Thu, Mar 15, 2018 at 2:15 PM, Scott Inglis <ms...@gmail.com> wrote:
>
> > I can start this today -- are there any concerns or questions regarding
> > these changes?
> >
>
> I don't seem to be able to build REEF using the new solution file:
>
> Invalid Resx file. Could not find file
> 'C:\src\reef\lang\cs\bin\.netcore\Debug\Org.Apache.REEF.
> Bridge\Org.Apache.REEF.Bridge.exe'.
> Line 79, position 5.
> C:\src\reef\lang\cs\Org.Apache.REEF.Client\Resources.DotNet.resx
>
> Any idea why that might be?
>
> Thanks,
>
> Markus
>
Re: C# VS 2017 Project Migration
Posted by Markus Weimer <ma...@weimo.de>.
On Thu, Mar 15, 2018 at 2:15 PM, Scott Inglis <ms...@gmail.com> wrote:
> I can start this today -- are there any concerns or questions regarding
> these changes?
>
I don't seem to be able to build REEF using the new solution file:
Invalid Resx file. Could not find file
'C:\src\reef\lang\cs\bin\.netcore\Debug\Org.Apache.REEF.Bridge\Org.Apache.REEF.Bridge.exe'.
Line 79, position 5.
C:\src\reef\lang\cs\Org.Apache.REEF.Client\Resources.DotNet.resx
Any idea why that might be?
Thanks,
Markus
Re: C# VS 2017 Project Migration
Posted by Byung-Gon Chun <bg...@gmail.com>.
Thanks for the update, Scott!
There has been many updates.
It'd be great if you'd share what version of .NET REEF supports too.
Thanks,
Gon
On Fri, Mar 16, 2018 at 6:15 AM, Scott Inglis <ms...@gmail.com> wrote:
> Hello,
>
> With the last change to the DotNet projects, we should now have the ability
> to switch to using the new projects.
>
> As part of the transition, my thoughts are to:
> 1) Switch AppVeyor to use target the new projects. (JIRA-1990
> https://issues.apache.org/jira/browse/REEF-1990)
> 2) Delete the old projects, rename the new projects to the name of the old
> projects (effectively removing the "DotNet" name on everything).
> (JIRA-1991 https://issues.apache.org/jira/browse/REEF-1991)
> 3) Remove any remaining build files. (also part of JIRA-1991)
>
> I can start this today -- are there any concerns or questions regarding
> these changes?
>
> Thanks,
>
> Scott
>
--
Byung-Gon Chun