You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Hobson (JIRA)" <ji...@codehaus.org> on 2007/05/18 18:21:58 UTC
[jira] Created: (MNG-2994) Snapshot repositories are not checked
when using ranges
Snapshot repositories are not checked when using ranges
-------------------------------------------------------
Key: MNG-2994
URL: http://jira.codehaus.org/browse/MNG-2994
Project: Maven 2
Issue Type: Bug
Components: Artifacts and Repositories
Affects Versions: 2.0.6
Environment: Windows XP, Cygwin
Reporter: Mark Hobson
Attachments: patch.txt
The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-2994) Snapshot repositories are
not checked when using ranges
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=217235#action_217235 ]
Benjamin Bentmann edited comment on MNG-2994 at 4/8/10 4:39 PM:
----------------------------------------------------------------
Fixed in [r932128|http://svn.apache.org/viewvc?view=revision&revision=932128].
In conformance with the fix for MNG-3092, snapshot repositories are now considered if any boundary of the version range explicitly refers to a snapshot.
was (Author: bentmann):
Fixed in [r932128|http://svn.apache.org/viewvc?view=revision&revision=932128].
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Benjamin Bentmann
> Fix For: 3.0-beta-1
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2994:
-------------------------------
Fix Version/s: (was: 2.2.2)
3.0-alpha-7
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: 3.0-alpha-7
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MNG-2994:
----------------------------
Fix Version/s: (was: 2.0.10)
2.0.11
This will need to wait until the other snapshots-in-version-ranges issue (referenced as a prerequisite for this issue) is resolved. Otherwise, we risk changing existing build behavior for version ranges in very bad ways.
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: 2.0.11
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2994:
-------------------------------
Patch Submitted: (was: [Yes])
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Attachments: patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2994:
---------------------------
Affects Version/s: (was: 2.0.10)
2.0.6
Fix Version/s: (was: Reviewed Pending Version Assignment)
2.0.10
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: 2.0.10
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hobson updated MNG-2994:
-----------------------------
Attachment: MNG-2994-2.patch
Updated IT patch to sync with current trunk by renaming it0121 to it0123 - please apply before someone adds another it0123!
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Attachments: MNG-2994-2.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-2994:
------------------------------
Patch Submitted: [Yes]
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: Reviewed Pending Version Assignment
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2994:
---------------------------
Affects Version/s: (was: 2.0.6)
2.0.10
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.10
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: Reviewed Pending Version Assignment
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hobson updated MNG-2994:
-----------------------------
Attachment: MNG-2994-3.patch
Attaching MNG-2994-3.patch which is a fix, rather than an IT.
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: Reviewed Pending Version Assignment
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-2994.
----------------------------------
Resolution: Fixed
Assignee: Benjamin Bentmann (was: Jason van Zyl)
Fixed in [r932128|http://svn.apache.org/viewvc?view=revision&revision=932128].
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Benjamin Bentmann
> Fix For: 3.0-beta-1
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_98706 ]
Brett Porter commented on MNG-2994:
-----------------------------------
I'd suggest adding a method that is an alternate to isSnapshot that is capable of expressing the difference, and use that from the metadata manager (retains backwards compat too).
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Attachments: patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_99595 ]
Mark Hobson commented on MNG-2994:
----------------------------------
Committed and commented-out attached it0123.
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: Reviewed Pending Version Assignment
>
> Attachments: MNG-2994-2.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hobson updated MNG-2994:
-----------------------------
Attachment: MNG-2994-core-it.patch
Attaching MNG-2994-core-it.patch that fixes it0043 in relation to this issue.
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Assignee: Jason van Zyl
> Fix For: Reviewed Pending Version Assignment
>
> Attachments: MNG-2994-2.patch, MNG-2994-3.patch, MNG-2994-core-it.patch, patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2994) Snapshot repositories are not checked
when using ranges
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_96454 ]
Mark Hobson commented on MNG-2994:
----------------------------------
After stepping through, it's actually ArtifactRepositoryMetadata.isSnapshot always returning false when queried by DefaultRepositoryMetadataManager.resolve. In turn, this is called by MavenMetadataSource.retrieveAvailableVersions from DefaultArtifactCollector.recurse when artifact.getVersion() == null, i.e. when ranges are being used.
> Snapshot repositories are not checked when using ranges
> -------------------------------------------------------
>
> Key: MNG-2994
> URL: http://jira.codehaus.org/browse/MNG-2994
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.6
> Environment: Windows XP, Cygwin
> Reporter: Mark Hobson
> Attachments: patch.txt
>
>
> The attached patch demonstrates the problem by adding it0121. If the test repository has releases enabled, the test passes, when they are disabled, the test fails. This appears to be due to DefaultArtifact.isSnapshot returning false for unresolved ranges, thus causing snapshot repositories to be disabled when resolving artifacts.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira