[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #811: NameMapping: reassign already mapped names for new columns

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #811: NameMapping: reassign already mapped names for new columns
URL: https://github.com/apache/incubator-iceberg/pull/811#discussion_r381023969
 
 

 ##########
 File path: core/src/test/java/org/apache/iceberg/mapping/TestMappingUpdates.java
 ##########
 @@ -216,34 +216,4 @@ public void testRenameComplexFieldMappingUpdate() {
             ))),
         pointUpdated.asMappedFields());
   }
-
-  @Test
-  public void testMappingUpdateFailureSkipsMappingUpdate() {
 
 Review comment:
   This test is no longer valid because there change that caused an exception while updating the mapping is now supported. Since there aren't changes that cause a failure and there isn't a good way to inject an implementation that fails, I'm just removing this test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org