[GitHub] [ozone] sadanand48 commented on a diff in pull request #3750: HDDS-7217. OM logs wrong bucket layout

[GitBox <gi...@apache.org>]

sadanand48 commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r971154801


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -632,6 +632,10 @@ public void createBucket(
     StorageType storageType = bucketArgs.getStorageType() == null ?
         StorageType.DEFAULT : bucketArgs.getStorageType();
     BucketLayout bucketLayout = bucketArgs.getBucketLayout();
+    if (bucketLayout == null) {
+      bucketLayout = BucketLayout
+          .fromString(conf.get(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT));

Review Comment:
   OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT is basically a OM server config and we are using it in client code but I guess we should be safe as OMConfigKeys is defined in the `common` module?



##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/bucket/TestOMBucketCreateRequestWithFSO.java:
##########
@@ -74,6 +112,23 @@ private OMBucketCreateRequest doPreExecute(String volumeName,
     return new OMBucketCreateRequest(modifiedRequest);
   }
 
+  private OMBucketCreateRequest

Review Comment:
   nit: We could avoid some code duplication here by creating method with `doPreExecute(String volumeName,String bucketName,ClientVersion cv)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org