[GitHub] [hive] pvary commented on a change in pull request #1235: HIVE-23830: Remove shutdownRunner runner after query is committed

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1235:
URL: https://github.com/apache/hive/pull/1235#discussion_r452616790



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -553,11 +553,13 @@ private void release(boolean releaseLocks) {
         LOG.warn("Exception when releasing locking in destroy: " + e.getMessage());
       }
     }
-    ShutdownHookManager.removeShutdownHook(shutdownRunner);
+    ShutdownHookManager.removeShutdownHook(txnRollbackRunner);
   }
 
   void releaseLocksAndCommitOrRollback(boolean commit) throws LockException {

Review comment:
       This method starts to look like a cleanup.
   Shall we separate out the functions to a different method, or just change the name?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org