You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "rohitYaduvanshi (via GitHub)" <gi...@apache.org> on 2025/01/13 16:02:36 UTC

[PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

rohitYaduvanshi opened a new pull request, #916:
URL: https://github.com/apache/incubator-baremaps/pull/916

   ### Description
   This PR improves the content of the `META-INF/MANIFEST.MF` file by adding more detailed and descriptive metadata entries, as requested in issue #907.  
   
   The following changes were made:
   - Added `Specification-Title` with a more descriptive value.
   - Updated `Specification-Vendor` to `Apache Software Foundation`.
   - Added `Implementation-Vendor` with the correct organization name.
   
   ### Changes
   - Updated Maven `maven-jar-plugin` configuration in `pom.xml` to include additional manifest entries.
   
   ### Issue Reference
   Resolves #907
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1913439704


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi Thanks for this PR. I guess we should probably add a <name> tag in all sub modules and use it to generate the Specification-Title. From what I understand, with this solution, all the generated jars will have the same specification title.
   
   <Specification-Title>${project.name} (incubating)</Specification-Title>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1915571987


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi I merged your commits in #917 as the plan is to start a release process later this week. Thanks a lot for the modification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1915571987


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi I merged your commits in #917 as the plan is to start a release process later this week. Thanks a lot for the modification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#issuecomment-2587552488

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=916) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=916&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=916&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=916&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=916&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=916&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=916)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1913439704


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi Thanks for this PR. I guess we should probably add a `<name>` tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to generate the Specification-Title dynamically. From what I understand, with the current solution, all the generated jars will have the same specification title.
   
   ```xml
   <name>baremaps-csv</name>
   
   ...
   
   <Specification-Title>${project.name}</Specification-Title>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1913439704


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi Thanks for this PR. I guess we should probably add a <name> tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to generate the Specification-Title dynamically. From what I understand, with this solution, all the generated jars will have the same specification title.
   
   <Specification-Title>${project.name} (incubating)</Specification-Title>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on code in PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#discussion_r1913439704


##########
pom.xml:
##########
@@ -719,8 +719,11 @@ limitations under the License.
           <archive>
             <manifestEntries>
               <Build-Date>${project.build.outputTimestamp}</Build-Date>
-              <Build-Version>${project.version}</Build-Version>
-              <Build-Jdk>${java.version}</Build-Jdk>
+                <Build-Version>${project.version}</Build-Version>
+                <Build-Jdk>${java.version}</Build-Jdk>
+                <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title>

Review Comment:
   @rohitYaduvanshi Thanks for this PR. I guess we should probably add a `<name>` tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to generate the Specification-Title dynamically. From what I understand, with the current solution, all the generated jars will have the same specification title.
   
   <name>baremaps-csv</name>
   
   ```xml
   <Specification-Title>${project.name}</Specification-Title>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis closed pull request #916: 907: Improve META-INF/MANIFEST.MF 
URL: https://github.com/apache/incubator-baremaps/pull/916


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#issuecomment-2587528250

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=916) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=916&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=916&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=916&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=916&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=916&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=916)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] 907: Improve META-INF/MANIFEST.MF [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #916:
URL: https://github.com/apache/incubator-baremaps/pull/916#issuecomment-2591062671

   @rohitYaduvanshi I merged your commits in #917 as the plan is to start a release process later this week. Thanks a lot for the modification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org