You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/07/10 22:24:47 UTC
Re: Review Request: FLUME-1310: Asynchbasesink test should work against
different hbase versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5524/#review9034
-----------------------------------------------------------
+1
- Mike Percy
On June 22, 2012, 7:12 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5524/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modified test to support whichever API is available.
>
>
> This addresses bug FLUME-1310.
> https://issues.apache.org/jira/browse/FLUME-1310
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java 3de651f
>
> Diff: https://reviews.apache.org/r/5524/diff/
>
>
> Testing
> -------
>
> Test only change. Verified test works against HBase-0.90.6 and Hbase-0.92
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1310: Asynchbasesink test should work against
different hbase versions
Posted by Mike Percy <mp...@gmail.com>.
> On July 10, 2012, 8:24 p.m., Mike Percy wrote:
> > +1
lgtm Hari, please attach the patch to the JIRA.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5524/#review9034
-----------------------------------------------------------
On June 22, 2012, 7:12 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5524/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 7:12 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modified test to support whichever API is available.
>
>
> This addresses bug FLUME-1310.
> https://issues.apache.org/jira/browse/FLUME-1310
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java 3de651f
>
> Diff: https://reviews.apache.org/r/5524/diff/
>
>
> Testing
> -------
>
> Test only change. Verified test works against HBase-0.90.6 and Hbase-0.92
>
>
> Thanks,
>
> Hari Shreedharan
>
>