You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ha...@apache.org on 2009/10/21 11:22:18 UTC
svn commit: r827935 - in /ofbiz/trunk/specialpurpose/projectmgr:
webapp/projectmgr/request/overViewRequestItems.ftl
widget/CustRequestScreens.xml
Author: hansbak
Date: Wed Oct 21 09:22:16 2009
New Revision: 827935
URL: http://svn.apache.org/viewvc?rev=827935&view=rev
Log:
add username to customeritem note list
Modified:
ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl
ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl (original)
+++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
@@ -68,6 +68,9 @@
${uiLabelMap.CommonNote}
</td>
<td>
+ ${uiLabelMap.PartyParty} ${uiLabelMap.PartyName}
+ </td>
+ <td>
${uiLabelMap.CommonDate}
</td>
</tr>
@@ -78,6 +81,7 @@
<#else>
<#assign row="alternate-row">
</#if>
+ <#assign partyNameView = delegator.findOne("PartyNameView", Static["org.ofbiz.base.util.UtilMisc"].toMap("partyId", custRequestItemNoteViewList.partyId), false)?if_exists/>
<tr class="${row}">
<td>
</td>
@@ -87,6 +91,9 @@
<td >
${custRequestItemNoteViewList.noteInfo}
</td>
+ <td >
+ ${partyNameView.groupName?if_exists} ${partyNameView.firstName?if_exists} ${partyNameView.lastName?if_exists}
+ </td>
<td>
${custRequestItemNoteViewList.noteDateTime.toString().substring(0,10)}
</td>
Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml?rev=827935&r1=827934&r2=827935&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml (original)
+++ ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml Wed Oct 21 09:22:16 2009
@@ -117,7 +117,7 @@
</entity-and>
<entity-condition entity-name="CustRequestItemNoteView" list="custRequestItemNoteViews">
<condition-expr field-name="custRequestId" operator="equals" from-field="parameters.custRequestId"/>
- <order-by field-name="-noteDateTime"/>
+ <order-by field-name="noteDateTime"/>
</entity-condition>
<entity-and entity-name="CustRequestContent" list="custRequestContents" filter-by-date="true">
<field-map field-name="custRequestId" from-field="custRequestId"/>
Re: svn commit: r827935 - in /ofbiz/trunk/specialpurpose/projectmgr: webapp/projectmgr/request/overViewRequestItems.ftl widget/CustRequestScreens.xml
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Hans - as I've said many times - thanks so much for continuing to add
new functionality to the project and help to push things forward. The
remaining question I have is, why does everyone have to watch your
commits so closely to ensure that crap does not continue to go back
into the project? I imagine that you must be just as tired as we are
of hearing it - doesn't that make you want to change the tact? I'm
not trying to be an ass, it's just got to be frustrating for everyone
involved and continues to make more work.
Cheers,
Ruppert
On Oct 21, 2009, at 3:59 AM, Scott Gray wrote:
> On 21/10/2009, at 10:22 PM, hansbak@apache.org wrote:
>> Author: hansbak
>> Date: Wed Oct 21 09:22:16 2009
>> New Revision: 827935
>>
>> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
>> Log:
>> add username to customeritem note list
>>
>> Modified:
>> ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl
>> ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>>
>> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
>> request/overViewRequestItems.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl (original)
>> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
>> @@ -68,6 +68,9 @@
>> ${uiLabelMap.CommonNote}
>> </td>
>> <td>
>> + ${uiLabelMap.PartyParty} $
>> {uiLabelMap.PartyName}
>> + </td>
>> + <td>
>
>
> This is bad for internationalization, you should make a new label
> instead of trying to combine existing labels.
>
> Regards
> Scott
Re: svn commit: r827935 - in /ofbiz/trunk/specialpurpose/projectmgr: webapp/projectmgr/request/overViewRequestItems.ftl widget/CustRequestScreens.xml
Posted by Anil Patel <an...@hotwaxmedia.com>.
Some more mess carelessly stuffed into Ofbiz. Lets hope cheap
providers would get careful so we can focus on enhancements.
Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com
http://us.apachecon.com/c/acus2009/sponsors/sponsors
On Oct 21, 2009, at 5:59 AM, Scott Gray wrote:
> On 21/10/2009, at 10:22 PM, hansbak@apache.org wrote:
>> Author: hansbak
>> Date: Wed Oct 21 09:22:16 2009
>> New Revision: 827935
>>
>> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
>> Log:
>> add username to customeritem note list
>>
>> Modified:
>> ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl
>> ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>>
>> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
>> request/overViewRequestItems.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl (original)
>> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
>> @@ -68,6 +68,9 @@
>> ${uiLabelMap.CommonNote}
>> </td>
>> <td>
>> + ${uiLabelMap.PartyParty} $
>> {uiLabelMap.PartyName}
>> + </td>
>> + <td>
>
>
> This is bad for internationalization, you should make a new label
> instead of trying to combine existing labels.
>
> Regards
> Scott
Re: svn commit: r827935 - in /ofbiz/trunk/specialpurpose/projectmgr: webapp/projectmgr/request/overViewRequestItems.ftl widget/CustRequestScreens.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
On 21/10/2009, at 10:22 PM, hansbak@apache.org wrote:
> Author: hansbak
> Date: Wed Oct 21 09:22:16 2009
> New Revision: 827935
>
> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
> Log:
> add username to customeritem note list
>
> Modified:
> ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl
> ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>
> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
> request/overViewRequestItems.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl (original)
> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
> @@ -68,6 +68,9 @@
> ${uiLabelMap.CommonNote}
> </td>
> <td>
> + ${uiLabelMap.PartyParty} $
> {uiLabelMap.PartyName}
> + </td>
> + <td>
This is bad for internationalization, you should make a new label
instead of trying to combine existing labels.
Regards
Scott