You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/05 06:43:52 UTC

[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #2832: Modify OracleDB connection string format.

gabrywu commented on pull request #2832:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2832#issuecomment-639290982


   > > It's better not to change the scope of appendDatabase. You can override the getJdbcUrl directly
   > 
   > At first I did getJdbcUrl modified, and then I noticed #2812 modification, I made changes based on this basis, and covered appendDatabase.
   > For now, do you want to rewrite getJdbcUrl instead? Any other suggestions? Looking forward for your response, thank you
   
   Oh dev-1.3.0 branch the getJdbcUrl method removed, maybe we should invite @lgcareer  to review this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org