[GitHub] [zeppelin] Reamer commented on a change in pull request #4266: [ZEPPELIN-5576] Improve Zeppelin CI

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4266:
URL: https://github.com/apache/zeppelin/pull/4266#discussion_r755919147



##########
File path: zeppelin-interpreter-integration/pom.xml
##########
@@ -24,7 +24,7 @@
     <artifactId>zeppelin</artifactId>
     <groupId>org.apache.zeppelin</groupId>
     <version>0.11.0-SNAPSHOT</version>
-    <relativePath>..</relativePath>
+    <relativePath>../pom.xml</relativePath>

Review comment:
       This line can be removed as this should be the default setting.

##########
File path: .github/workflows/core.yml
##########
@@ -441,6 +358,11 @@ jobs:
           key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-zeppelin-
+      - name: install environment
+        run: |
+          ./mvnw install -DskipTests -DskipRat -pl livy -am  -B
+          ./testing/downloadSpark.sh "2.2.0" "2.6"

Review comment:
       Maybe it's time to update the Spark version to 2.4.

##########
File path: spark/interpreter/pom.xml
##########
@@ -113,6 +113,13 @@
       </exclusions>
     </dependency>
 
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
+      <artifactId>hadoop-client</artifactId>

Review comment:
       Duplicate dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org