You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2016/04/27 14:43:28 UTC
[FALCONJX] Jdk 1.6 incompatability in debugger module
Hi,
I just implemented the Maven build for the debugger module and encountered a problem.
As I configured the animal-sniffer-plugin to check the output for compatibility with JDK 1.6, the plugin started complaining that it's not possible to use DebugCLI on a 1.6 VM. The line it's complaining about is 487:
getLocalizationManager().setLocale(LocaleUtility.langToLocale(args[++i]));
Seems to be incompatible to 1.6. How do we proceed here? As it's getting impossible to get my hands on a 1.6 VM on my Mac I would like to update to 1.7 as base-line Java Version, what do you think? If we can't get the environment, how should we support it? Or we refactor this line so it's compatible with 1.6.
I'm commenting that line out for now ... we should however solve the problem somehow.
Chris
AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
Posted by Christofer Dutz <ch...@c-ware.de>.
I solved the problem by replacing the implementation of that logic by one shipped with apache-commons-lang.
This should get rid of my error and remove the warning in the build too. But I guess you need an additional dependency in the Ant build now
Chris
________________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Mittwoch, 27. April 2016 15:31:35
An: dev@flex.apache.org
Betreff: AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
Ok so I guess this is something different. I found an old PC with Java 1.6 and had a look at it. It seems that the JDK seems to provide the method.
Strange ... eventually the signature was excluded from the animal-sniffer signature package for 1.6 as it's an internal package. Think I'll have to find out a way to mark this as a false positive.
Chris
________________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Mittwoch, 27. April 2016 15:22:44
An: dev@flex.apache.org
Betreff: AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
No, this is if you execute the maven build.
It's the animal-sniffer-plugin (http://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/) that's complaining.
Not only should we not use it cause it's internal, it also doesn't seem to be available in 1.6
[INFO] --- animal-sniffer-maven-plugin:1.15:check (check-jdk-1.6) @ debugger ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1
[ERROR] /Users/christoferdutz/Projects/Apache/Flex/flex-falcon/debugger/src/main/java/flex/tools/debugger/cli/DebugCLI.java:488: Undefined reference: java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
So it claims the call "java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)" doesn't exist in the signature of Java 1.6
Chris
________________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Mittwoch, 27. April 2016 15:08:08
An: dev@flex.apache.org
Betreff: Re: [FALCONJX] Jdk 1.6 incompatability in debugger module
For me, it is a warning:
/Users/aharui/git/flex/master/flex-falcon/debugger/src/main/java/flex/tools
/debugger/cli/DebugCLI.java:487: warning: LocaleUtility is internal
proprietary API and may be removed in a future release
Maybe there is a way to turn your error into a warning? Or a replacement
for LocaleUtility?
-Alex
On 4/27/16, 5:43 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi,
>
>
>I just implemented the Maven build for the debugger module and
>encountered a problem.
>
>
>As I configured the animal-sniffer-plugin to check the output for
>compatibility with JDK 1.6, the plugin started complaining that it's not
>possible to use DebugCLI on a 1.6 VM. The line it's complaining about is
>487:
>
>
>getLocalizationManager().setLocale(LocaleUtility.langToLocale(args[++i]));
>
>
>Seems to be incompatible to 1.6. How do we proceed here? As it's getting
>impossible to get my hands on a 1.6 VM on my Mac I would like to update
>to 1.7 as base-line Java Version, what do you think? If we can't get the
>environment, how should we support it? Or we refactor this line so it's
>compatible with 1.6.
>
>
>I'm commenting that line out for now ... we should however solve the
>problem somehow.
>
>
>Chris
>
AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok so I guess this is something different. I found an old PC with Java 1.6 and had a look at it. It seems that the JDK seems to provide the method.
Strange ... eventually the signature was excluded from the animal-sniffer signature package for 1.6 as it's an internal package. Think I'll have to find out a way to mark this as a false positive.
Chris
________________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Mittwoch, 27. April 2016 15:22:44
An: dev@flex.apache.org
Betreff: AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
No, this is if you execute the maven build.
It's the animal-sniffer-plugin (http://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/) that's complaining.
Not only should we not use it cause it's internal, it also doesn't seem to be available in 1.6
[INFO] --- animal-sniffer-maven-plugin:1.15:check (check-jdk-1.6) @ debugger ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1
[ERROR] /Users/christoferdutz/Projects/Apache/Flex/flex-falcon/debugger/src/main/java/flex/tools/debugger/cli/DebugCLI.java:488: Undefined reference: java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
So it claims the call "java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)" doesn't exist in the signature of Java 1.6
Chris
________________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Mittwoch, 27. April 2016 15:08:08
An: dev@flex.apache.org
Betreff: Re: [FALCONJX] Jdk 1.6 incompatability in debugger module
For me, it is a warning:
/Users/aharui/git/flex/master/flex-falcon/debugger/src/main/java/flex/tools
/debugger/cli/DebugCLI.java:487: warning: LocaleUtility is internal
proprietary API and may be removed in a future release
Maybe there is a way to turn your error into a warning? Or a replacement
for LocaleUtility?
-Alex
On 4/27/16, 5:43 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi,
>
>
>I just implemented the Maven build for the debugger module and
>encountered a problem.
>
>
>As I configured the animal-sniffer-plugin to check the output for
>compatibility with JDK 1.6, the plugin started complaining that it's not
>possible to use DebugCLI on a 1.6 VM. The line it's complaining about is
>487:
>
>
>getLocalizationManager().setLocale(LocaleUtility.langToLocale(args[++i]));
>
>
>Seems to be incompatible to 1.6. How do we proceed here? As it's getting
>impossible to get my hands on a 1.6 VM on my Mac I would like to update
>to 1.7 as base-line Java Version, what do you think? If we can't get the
>environment, how should we support it? Or we refactor this line so it's
>compatible with 1.6.
>
>
>I'm commenting that line out for now ... we should however solve the
>problem somehow.
>
>
>Chris
>
AW: [FALCONJX] Jdk 1.6 incompatability in debugger module
Posted by Christofer Dutz <ch...@c-ware.de>.
No, this is if you execute the maven build.
It's the animal-sniffer-plugin (http://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/) that's complaining.
Not only should we not use it cause it's internal, it also doesn't seem to be available in 1.6
[INFO] --- animal-sniffer-maven-plugin:1.15:check (check-jdk-1.6) @ debugger ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1
[ERROR] /Users/christoferdutz/Projects/Apache/Flex/flex-falcon/debugger/src/main/java/flex/tools/debugger/cli/DebugCLI.java:488: Undefined reference: java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
So it claims the call "java.util.Locale com.sun.org.apache.xml.internal.utils.LocaleUtility.langToLocale(String)" doesn't exist in the signature of Java 1.6
Chris
________________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Mittwoch, 27. April 2016 15:08:08
An: dev@flex.apache.org
Betreff: Re: [FALCONJX] Jdk 1.6 incompatability in debugger module
For me, it is a warning:
/Users/aharui/git/flex/master/flex-falcon/debugger/src/main/java/flex/tools
/debugger/cli/DebugCLI.java:487: warning: LocaleUtility is internal
proprietary API and may be removed in a future release
Maybe there is a way to turn your error into a warning? Or a replacement
for LocaleUtility?
-Alex
On 4/27/16, 5:43 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi,
>
>
>I just implemented the Maven build for the debugger module and
>encountered a problem.
>
>
>As I configured the animal-sniffer-plugin to check the output for
>compatibility with JDK 1.6, the plugin started complaining that it's not
>possible to use DebugCLI on a 1.6 VM. The line it's complaining about is
>487:
>
>
>getLocalizationManager().setLocale(LocaleUtility.langToLocale(args[++i]));
>
>
>Seems to be incompatible to 1.6. How do we proceed here? As it's getting
>impossible to get my hands on a 1.6 VM on my Mac I would like to update
>to 1.7 as base-line Java Version, what do you think? If we can't get the
>environment, how should we support it? Or we refactor this line so it's
>compatible with 1.6.
>
>
>I'm commenting that line out for now ... we should however solve the
>problem somehow.
>
>
>Chris
>
Re: [FALCONJX] Jdk 1.6 incompatability in debugger module
Posted by Alex Harui <ah...@adobe.com>.
For me, it is a warning:
/Users/aharui/git/flex/master/flex-falcon/debugger/src/main/java/flex/tools
/debugger/cli/DebugCLI.java:487: warning: LocaleUtility is internal
proprietary API and may be removed in a future release
Maybe there is a way to turn your error into a warning? Or a replacement
for LocaleUtility?
-Alex
On 4/27/16, 5:43 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi,
>
>
>I just implemented the Maven build for the debugger module and
>encountered a problem.
>
>
>As I configured the animal-sniffer-plugin to check the output for
>compatibility with JDK 1.6, the plugin started complaining that it's not
>possible to use DebugCLI on a 1.6 VM. The line it's complaining about is
>487:
>
>
>getLocalizationManager().setLocale(LocaleUtility.langToLocale(args[++i]));
>
>
>Seems to be incompatible to 1.6. How do we proceed here? As it's getting
>impossible to get my hands on a 1.6 VM on my Mac I would like to update
>to 1.7 as base-line Java Version, what do you think? If we can't get the
>environment, how should we support it? Or we refactor this line so it's
>compatible with 1.6.
>
>
>I'm commenting that line out for now ... we should however solve the
>problem somehow.
>
>
>Chris
>