You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by yo...@apache.org on 2023/06/19 07:42:36 UTC
[bookkeeper] 12/31: recycle dropping read-write requests when various exceptions happened (#3912)
This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch branch-4.16
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
commit 36043c3ffe223a0cdc97b6162907f51d036587a6
Author: wenbingshen <ol...@gmail.com>
AuthorDate: Wed Apr 26 13:54:24 2023 +0800
recycle dropping read-write requests when various exceptions happened (#3912)
(cherry picked from commit 3a9fe1b2874dd238766569895175ce2e9cabcabf)
---
.../src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java | 1 +
.../src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java | 2 ++
2 files changed, 3 insertions(+)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
index c44216a028..4c9c1c9440 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java
@@ -65,6 +65,7 @@ class ReadEntryProcessor extends PacketProcessorBase<ReadRequest> {
LOG.debug("Dropping read request for closed channel: {}", requestHandler.ctx().channel());
}
requestProcessor.onReadRequestFinish();
+ recycle();
return;
}
int errorCode = BookieProtocol.EOK;
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java
index 29b3a5abb7..0cd01c7970 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java
@@ -65,6 +65,7 @@ class WriteEntryProcessor extends PacketProcessorBase<ParsedAddRequest> implemen
requestProcessor.getRequestStats().getAddRequestStats());
request.release();
request.recycle();
+ recycle();
return;
}
@@ -109,6 +110,7 @@ class WriteEntryProcessor extends PacketProcessorBase<ParsedAddRequest> implemen
ResponseBuilder.buildErrorResponse(rc, request),
requestProcessor.getRequestStats().getAddRequestStats());
request.recycle();
+ recycle();
}
}