You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2012/06/08 18:33:23 UTC
[jira] [Created] (LUCENE-4122) Replace Payload with BytesRef
Andrzej Bialecki created LUCENE-4122:
-----------------------------------------
Summary: Replace Payload with BytesRef
Key: LUCENE-4122
URL: https://issues.apache.org/jira/browse/LUCENE-4122
Project: Lucene - Java
Issue Type: Improvement
Components: core/index
Affects Versions: 4.0, 5.0
Reporter: Andrzej Bialecki
Assignee: Andrzej Bialecki
Fix For: 4.0, 5.0
The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.
This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4122) Replace Payload with BytesRef
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated LUCENE-4122:
--------------------------------------
Attachment: LUCENE-4122.patch
Patch for trunk. All tests pass.
> Replace Payload with BytesRef
> -----------------------------
>
> Key: LUCENE-4122
> URL: https://issues.apache.org/jira/browse/LUCENE-4122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0, 5.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4122.patch
>
>
> The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.
> This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4122) Replace Payload with BytesRef
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291862#comment-13291862 ]
Robert Muir commented on LUCENE-4122:
-------------------------------------
+1
> Replace Payload with BytesRef
> -----------------------------
>
> Key: LUCENE-4122
> URL: https://issues.apache.org/jira/browse/LUCENE-4122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0, 5.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4122.patch
>
>
> The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.
> This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4122) Replace Payload with BytesRef
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291865#comment-13291865 ]
Michael McCandless commented on LUCENE-4122:
--------------------------------------------
+1
> Replace Payload with BytesRef
> -----------------------------
>
> Key: LUCENE-4122
> URL: https://issues.apache.org/jira/browse/LUCENE-4122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0, 5.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4122.patch
>
>
> The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.
> This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4122) Replace Payload with BytesRef
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki resolved LUCENE-4122.
---------------------------------------
Resolution: Fixed
Committed in rev. 1348171 to trunk and in rev. 1348227 to branch_4x.
> Replace Payload with BytesRef
> -----------------------------
>
> Key: LUCENE-4122
> URL: https://issues.apache.org/jira/browse/LUCENE-4122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0, 5.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4122.patch
>
>
> The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.
> This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org