You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by suez1224 <gi...@git.apache.org> on 2018/01/10 09:21:45 UTC
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
GitHub user suez1224 opened a pull request:
https://github.com/apache/flink/pull/5274
[FLINK-8401][Cassandra Connector]Refactor CassandraOutputFormat to allow subclass to customize the faiā¦
## What is the purpose of the change
Refactor CassandraOutputFormat to allow subclass to customize the failure handling logic.
## Brief change log
- Added to protected methods for handling cassandra write result, these allow subclass to override them to customize.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suez1224/flink flink-8401
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5274
----
commit 8f6ae5636e549d7fe2f0788591acc8880c01af45
Author: Shuyi Chen <sh...@...>
Date: 2018-01-10T09:17:55Z
Refactor CassandraOutputFormat to allow subclass to customize the failure handling logic
----
---
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5274#discussion_r161489425
--- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java ---
@@ -66,6 +66,13 @@ public void configure(Configuration parameters) {
this.cluster = builder.getCluster();
}
+ protected void onWriteSuccess(ResultSet ignored) {
+ }
+
+ protected void onWriteFailure(Throwable t) {
--- End diff --
JavaDocs missing
---
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5274#discussion_r161489395
--- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java ---
@@ -66,6 +66,13 @@ public void configure(Configuration parameters) {
this.cluster = builder.getCluster();
}
+ protected void onWriteSuccess(ResultSet ignored) {
--- End diff --
JavaDocs missing
---
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5274
---
[GitHub] flink issue #5274: [FLINK-8401][Cassandra Connector]Refactor CassandraOutput...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5274
@tillrohrmann , can you help take another look?
---
[GitHub] flink issue #5274: [FLINK-8401][Cassandra Connector]Refactor CassandraOutput...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on the issue:
https://github.com/apache/flink/pull/5274
Thanks a lot, @tillrohrmann . Added javadoc. Please take another look.
---
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5274#discussion_r161672687
--- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java ---
@@ -66,6 +66,13 @@ public void configure(Configuration parameters) {
this.cluster = builder.getCluster();
}
+ protected void onWriteSuccess(ResultSet ignored) {
--- End diff --
JavaDoc added.
---
[GitHub] flink issue #5274: [FLINK-8401][Cassandra Connector]Refactor CassandraOutput...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5274
Looks good to me.
Will merge this.
---
[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...
Posted by suez1224 <gi...@git.apache.org>.
Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5274#discussion_r161672700
--- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java ---
@@ -66,6 +66,13 @@ public void configure(Configuration parameters) {
this.cluster = builder.getCluster();
}
+ protected void onWriteSuccess(ResultSet ignored) {
+ }
+
+ protected void onWriteFailure(Throwable t) {
--- End diff --
JavaDoc added.
---