You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/09/19 23:57:19 UTC

[GitHub] [incubator-sedona] sekikn opened a new pull request, #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

sekikn opened a new pull request, #692:
URL: https://github.com/apache/incubator-sedona/pull/692

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-170. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   
   - This PR adds ST_AddPoint and ST_RemovePoint to the Flink API.
   
   ## How was this patch tested?
   
   - Ran `mvn clean install` locally
   - Ran `mkdocs serve` and checked the generated API document
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I am adding a new API. I am using the [1.3.0](https://github.com/apache/incubator-sedona/blob/master/pom.xml#L29) in since `vX.Y.Z` format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #692:
URL: https://github.com/apache/incubator-sedona/pull/692#issuecomment-1254538260

   This looks interesting. Does Flink already support ESRI geometry type before your PR? I checked their doc (https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/types/#data-types-in-the-table-api): Geometry is not listed as primitive type.
   
   In addition, some functions such as spatial aggregation might be able to be ported from Calcite to Flink. Some functions such as ST_Subdivide are actually implemented by Sedona committers for Spark. We just simply port them to Flink.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #692:
URL: https://github.com/apache/incubator-sedona/pull/692


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] bchapuis commented on pull request #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

Posted by GitBox <gi...@apache.org>.
bchapuis commented on PR #692:
URL: https://github.com/apache/incubator-sedona/pull/692#issuecomment-1252805210

   @sekikn In my understanding Apache Flink uses Apache Calcite under the hood. Is that right? Would it make sense to implement these spatial functions directly in Calcite? Here are some recent changes made in calcite relevant to this issue:
   
   https://github.com/apache/calcite/commit/262492527fbd450892df36cda38080d447fc6498 
   https://github.com/apache/calcite/commit/250d13c566913ba541ddd7ac4c4443a11a1a976b


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] bchapuis commented on pull request #692: [SEDONA-170] Add ST_AddPoint and ST_RemovePoint to the Flink API

Posted by GitBox <gi...@apache.org>.
bchapuis commented on PR #692:
URL: https://github.com/apache/incubator-sedona/pull/692#issuecomment-1254617761

   I'm not using Flink and I don't know exactly how they use Calcite. Before my PR, calcite used the ESRI geometry API, it now uses JTS and proj4j. I started working implicit conversion (text => geometry), aggregation function (Accum, Union, etc.), and try to figure out how to implement other special functions such as (ST_Explode).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org